Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #57425: Support passing kube-scheduler policy config #57924

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Automated cherry pick of #57425: Support passing kube-scheduler policy config #57924

merged 1 commit into from
Jan 8, 2018

Conversation

yguo0905
Copy link
Contributor

@yguo0905 yguo0905 commented Jan 6, 2018 •
edited
Loading

Cherry pick of #57425 on release-1.9.

#57425: Support passing kube-scheduler policy config

GCE: support passing kube-scheduler policy config via SCHEDULER_POLICY_CONFIG

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 6, 2018
@yguo0905
Copy link
Contributor Author

yguo0905 commented Jan 6, 2018

/cc @mbohlool

@k8s-ci-robot k8s-ci-robot requested a review from mbohlool January 6, 2018 02:59
@yguo0905
Copy link
Contributor Author

yguo0905 commented Jan 6, 2018

@mbohlool, this is a GCE cluster script change with very low risk. Can you please take a look?

@mbohlool
Copy link
Contributor

mbohlool commented Jan 8, 2018 •
edited
Loading

@yguo0905 Sure. Should we include a release note?

(transferred LGTM and approval from parent PR)

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: yguo0905

Associated issue: #57425

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mbohlool mbohlool added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 8, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@yguo0905
Copy link
Contributor Author

yguo0905 commented Jan 8, 2018

@yguo0905 Sure. Should we include a release note?

Done. Thanks!

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 3a70b35 into kubernetes:release-1.9 Jan 8, 2018
@yguo0905 yguo0905 deleted the automated-cherry-pick-of-#57425-upstream-release-1.9 branch January 8, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees

@vishh vishh

@jszczepkowski jszczepkowski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yguo0905 @mbohlool @k8s-ci-robot @k8s-github-robot @vishh @jszczepkowski