Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #57192: Reduce CPU request of Dasboard addon #57551

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Automated cherry pick of #57192: Reduce CPU request of Dasboard addon #57551

merged 1 commit into from
Jan 3, 2018

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Dec 22, 2017 •
edited
Loading

Cherry pick of #57192 on release-1.9.

#57192: Reduce CPU request of Dasboard addon

Release note:

Free up CPU requested but unused by Kubernetes Dashboard.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 22, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 22, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2017
@kawych
Copy link
Contributor Author

kawych commented Dec 22, 2017

/assign @mbohlool
To review cherry-pick

/unassign @jbeda
/unassign @zmerlynn
/assign @x13n
/assign @mikedanese

@k8s-ci-robot k8s-ci-robot assigned mbohlool, mikedanese and x13n and unassigned jbeda and zmerlynn Dec 22, 2017
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 22, 2017
@kawych
Copy link
Contributor Author

kawych commented Dec 22, 2017

/test pull-kubernetes-unit

@x13n
Copy link
Member

x13n commented Dec 22, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2017
@mbohlool
Copy link
Contributor

Is this fixing a bug or issue? I can't find a related issue. Also What is the user impact and why it is important to cherry pick this into 1.9?

@mbohlool
Copy link
Contributor

/test pull-kubernetes-e2e-kops-aws

@mbohlool
Copy link
Contributor

mbohlool commented Jan 2, 2018 •
edited
Loading

@kawych @mikedanese @piosz @bryk

(cc'ed people from parent PR)

This cherrypick is inactive for 11 days. The deadline for 1.9.1 cherry pick approvals is today. Please update the PR with the answer to these questions:

Is this fixing a bug or issue? I can't find a related issue. Also What is the user impact and why it is important to cherry pick this into 1.9?

Also tests are failing.

@kawych
Copy link
Contributor Author

kawych commented Jan 2, 2018

Analogously to #57462, the problem is that resource requirements are set too high for some addons (Dashboard in this case). This is in the context of new addons, i.e. Metrics Server that was introduced in 1.8, Metadata Agent introduced in 1.9 (now disabled by default). On small clusters the addons are using up increasing fraction of resources (the biggest effect is visible on 1-node clusters), this PR aims to mitigate that. As discussed with @bryk this change is safe for Kubernetes Dashboard.

User impact of this bug:

  • low (and getting lower) available resources on small clusters
  • possible evictions of user workloads with cluster upgrades

@kawych
Copy link
Contributor Author

kawych commented Jan 2, 2018

/retest

@kawych
Copy link
Contributor Author

kawych commented Jan 2, 2018

@mbohlool
Looks like the tests are failing due to #57728.

@mbohlool
Copy link
Contributor

mbohlool commented Jan 2, 2018

/retest

@mbohlool
Copy link
Contributor

mbohlool commented Jan 3, 2018

@kawych thanks for explanation. The PR still needs approval from anyone in this list: https://github.com/kubernetes/kubernetes/blob/master/cluster/OWNERS

I will approve it for cherrypick but please find somebody from that list to approve it.

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 3, 2018
@mbohlool
Copy link
Contributor

mbohlool commented Jan 3, 2018

/retest

@mbohlool
Copy link
Contributor

mbohlool commented Jan 3, 2018 •
edited
Loading

I think I had some power to approve this as an exception. The change looks simple and I trust the approval on parent PR.

@mbohlool mbohlool added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kawych, x13n

Associated issue: #57192

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 362cd65 into kubernetes:release-1.9 Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@x13n x13n

@mbohlool mbohlool

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kawych @x13n @mbohlool @k8s-ci-robot @k8s-github-robot @jbeda @mikedanese @zmerlynn