Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix format string in flex pv describer #57406

Closed
wants to merge 1 commit into from

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Dec 19, 2017

What this PR does / why we need it:
This PR fixes bug in the Flex Persistent Volume Source describer.

It happened because format string was accidentally split to 2 strings and was interpreted in a wrong way.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
/assign @smarterclayton @php-coder

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2017
@dixudx dixudx force-pushed the fix_flex_pvc_describer branch from 879d60a to 38e20f6 Compare December 19, 2017 14:16
@dixudx dixudx changed the title fix format string in flex pvc describer fix format string in flex pv describer Dec 19, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dixudx
We suggest the following additional approver: smarterclayton

Assign the PR to them by writing /assign @smarterclayton in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@php-coder
Copy link
Contributor

@dixudx I've already submitted #57399 :)

@dixudx
Copy link
Member Author

dixudx commented Dec 19, 2017

@php-coder Thanks.
/close

@php-coder
Copy link
Contributor

Duplicate of #57399

@dixudx dixudx deleted the fix_flex_pvc_describer branch December 19, 2017 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants