Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #52929 #57056

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Automated cherry pick of #52929 #57056

merged 1 commit into from
Dec 12, 2017

Conversation

krousey
Copy link
Contributor

@krousey krousey commented Dec 11, 2017 •
edited by enisoc
Loading

Cherry pick of #52929 on release-1.8.

#52929: Add cos as an alias for gci in the upgrade script

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 11, 2017
@krousey
Copy link
Contributor Author

krousey commented Dec 11, 2017

cc @enisoc This should have made the 1.8 release, but it missed it. So here's the cherry-pick. I'm hoping this will clean up the downgrade results.

@enisoc enisoc added this to the v1.8 milestone Dec 11, 2017
@enisoc enisoc added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. status/approved-for-milestone labels Dec 11, 2017
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 11, 2017
@enisoc enisoc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 11, 2017
@enisoc
Copy link
Member

enisoc commented Dec 11, 2017

/lgtm

Approving for cherrypick after checking with @jpbetz since this is intended to help 1.9 downgrade tests.

#56244

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: enisoc, krousey

Associated issue: #52929

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@enisoc enisoc mentioned this pull request Dec 11, 2017
Closed
@enisoc enisoc added sig/gcp kind/bug Categorizes issue or PR as related to a bug. labels Dec 11, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@enisoc @krousey

Pull Request Labels
  • sig/gcp: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@enisoc
Copy link
Member

enisoc commented Dec 11, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 25537ba into kubernetes:release-1.8 Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enisoc enisoc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@krousey @enisoc @k8s-ci-robot @k8s-github-robot