Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GKE failure, set default in configure.sh. #55331

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Fix GKE failure, set default in configure.sh. #55331

merged 1 commit into from
Nov 9, 2017
+1 −1

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Nov 8, 2017 •
edited
Loading

Fixes #55189.

Signed-off-by: Lantao Liu lantaol@google.com
Release note:

none

@Random-Liu
Fix GKE failure, set default in configure.sh.
45b3301 
Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2017
@Random-Liu
Copy link
Member Author

Fixes #55189.

@spiffxp @yliaog

@Random-Liu Random-Liu assigned spiffxp and unassigned bowei and jszczepkowski Nov 8, 2017
@Random-Liu Random-Liu added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 8, 2017
@Random-Liu Random-Liu mentioned this pull request Nov 8, 2017
Closed
@bowei
Copy link
Member

bowei commented Nov 8, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2017
@bowei
Copy link
Member

bowei commented Nov 8, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bowei, Random-Liu

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2017
@Random-Liu
Copy link
Member Author

/test pull-kubernetes-unit

@enisoc enisoc added this to the v1.9 milestone Nov 8, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55331, 55272, 55228, 49763, 55242). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit ff9574a into kubernetes:master Nov 9, 2017
@k8s-ci-robot
Copy link
Contributor

@Random-Liu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 45b3301 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Random-Liu Random-Liu deleted the fix-gke-failure branch November 9, 2017 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spiffxp spiffxp

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
7 participants
@Random-Liu @bowei @k8s-github-robot @k8s-ci-robot @spiffxp @enisoc @jszczepkowski