Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify confusing deprecation comment for generic top level prefix proxy. #55049

Closed
wants to merge 2 commits into from
Closed

Modify confusing deprecation comment for generic top level prefix proxy. #55049

wants to merge 2 commits into from

Conversation

xiangpengzhao
Copy link
Contributor

@xiangpengzhao xiangpengzhao commented Nov 3, 2017 •
edited
Loading

What this PR does / why we need it:
The current comment is confusing.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 3, 2017
@xiangpengzhao xiangpengzhao changed the title Remove generic top level prefix proxy. Modify confusing deprecation comment for generic top level prefix proxy. Nov 3, 2017
@enj
Copy link
Member

enj commented Nov 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enj, xiangpengzhao
We suggest the following additional approver: deads2k

Assign the PR to them by writing /assign @deads2k in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@xiangpengzhao
Copy link
Contributor Author

/assign @deads2k

deads2k
deads2k reviewed Nov 9, 2017
View reviewed changes
staging/src/k8s.io/apiserver/pkg/endpoints/installer.go Outdated
@@ -427,10 +427,8 @@ func (a *APIInstaller) registerResourceHandlers(path string, storage rest.Storag
actions = appendIf(actions, action{"DELETE", itemPath, nameParams, namer, false}, isDeleter)
actions = appendIf(actions, action{"WATCH", "watch/" + itemPath, nameParams, namer, false}, isWatcher)
// We add "proxy" subresource to remove the need for the generic top level prefix proxy.
// The generic top level prefix proxy is deprecated in v1.2, and will be removed in 1.3, or 1.4 at the latest.
// TODO: DEPRECATED in v1.2.
// The generic top level prefix proxy is deprecated in v1.2, and should be removed in v2 API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updated comment isn't correct. The original is correct. The top level proxy should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I once tried to remove it but some tests failed. Seems like something still depends on it. I will reproduce it.

@deads2k deads2k added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 9, 2017
@k8s-github-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @deads2k @enj @timothysc @xiangpengzhao

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2017
@xiangpengzhao
Copy link
Contributor Author

@deads2k I found some discussions : #30259 (comment)
As a testing, I remove the code in a separate commit to see if the CI will be happy :)

/cc @nikhiljindal

@k8s-ci-robot
Copy link
Contributor

@xiangpengzhao: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit cfa4a5b link /test pull-kubernetes-unit
pull-kubernetes-verify cfa4a5b link /test pull-kubernetes-verify
pull-kubernetes-e2e-gce cfa4a5b link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-kops-aws cfa4a5b link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-node-e2e cfa4a5b link /test pull-kubernetes-node-e2e
pull-kubernetes-bazel-test cfa4a5b link /test pull-kubernetes-bazel-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@timothysc timothysc removed their assignment Nov 29, 2017
@k8s-github-robot
Copy link

This PR hasn't been active in 30 days. It will be closed in 59 days (Feb 8, 2018).

cc @deads2k @enj @xiangpengzhao

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

@xiangpengzhao
Copy link
Contributor Author

kindly ping @nikhiljindal for confirmation :)

@xiangpengzhao
Copy link
Contributor Author

/close
in favor of #59884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@nikhiljindal nikhiljindal Awaiting requested review from nikhiljindal

Assignees

@enj enj

@deads2k deads2k

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xiangpengzhao @enj @k8s-github-robot @k8s-ci-robot @deads2k @timothysc