-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests on OS X by re-introducing the old choose host interface #5397
Conversation
function as a fall back.
LGTM. I checked this out and ran the tests successfully on OS X. |
@brendandburns the issue is not with util.go it was an issue with proxy_test.go |
Self assigning since I can't seem to assign this to @markturansky |
@satnam6502 can u pls check 5400 |
I am currently testing #5400 |
I assigned #5400 to @brendandburns but happy to re-assign or take it myself. |
Is this OK to merge? |
@satnam6502 not sure if this conflicts with #5400. both work, though :) |
@satnam6502 this is not the correct fix , #5400 is the correct one |
Ah, OK. Should this PR be closed then? |
yes , closed. |
I don't think that #5400 is sufficient. We should be able to run the proxy on OS X, not just the proxy unit tests. --brendan |
@brendanburns Ahh ok this i what I wanted to confirm whether we run kube on mac(Unix) |
I would like to be able to run standalone kube w/ boot2docker --brendan On Thu, Mar 12, 2015 at 2:20 PM, sub-mod notifications@github.com wrote:
|
@brendanburns can we apply both the PRs. |
fine with me to apply both. On Thu, Mar 12, 2015 at 2:25 PM, sub-mod notifications@github.com wrote:
|
@satnam6502 fyi |
OK, merging. |
Fix tests on OS X by re-introducing the old choose host interface
@brendanburns Proxy still fails on OS X. Would you like a PR for it? This PR fixes the unit tests successfully. This is my /tmp/kube-proxy.log:
|
it is choosing ipv6 IP , |
I'll make a new PR will all my steps, logs, etc. |
No need. There's still this open issue with services on OS X: #2170 |
Old function is a fall back.