Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on OS X by re-introducing the old choose host interface #5397

Merged
merged 1 commit into from
Mar 12, 2015

Conversation

brendandburns
Copy link
Contributor

Old function is a fall back.

@erictune
Copy link
Member

@sub-mod

@markturansky
Copy link
Contributor

LGTM.

I checked this out and ran the tests successfully on OS X.

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

@brendandburns the issue is not with util.go it was an issue with proxy_test.go

@satnam6502 satnam6502 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2015
@satnam6502 satnam6502 self-assigned this Mar 12, 2015
@satnam6502
Copy link
Contributor

Self assigning since I can't seem to assign this to @markturansky

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

@satnam6502 can u pls check 5400

@markturansky
Copy link
Contributor

I am currently testing #5400

@satnam6502
Copy link
Contributor

I assigned #5400 to @brendandburns but happy to re-assign or take it myself.

@satnam6502
Copy link
Contributor

Is this OK to merge?

@markturansky
Copy link
Contributor

@satnam6502 not sure if this conflicts with #5400. both work, though :)

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

@satnam6502 this is not the correct fix , #5400 is the correct one

@satnam6502 satnam6502 removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2015
@satnam6502
Copy link
Contributor

Ah, OK. Should this PR be closed then?

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

yes , closed.

@brendandburns
Copy link
Contributor Author

I don't think that #5400 is sufficient. We should be able to run the proxy on OS X, not just the proxy unit tests.

--brendan

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

@brendanburns Ahh ok this i what I wanted to confirm whether we run kube on mac(Unix)

@brendandburns
Copy link
Contributor Author

I would like to be able to run standalone kube w/ boot2docker

--brendan

On Thu, Mar 12, 2015 at 2:20 PM, sub-mod notifications@github.com wrote:

@brendanburns https://github.com/brendanburns Ahh ok this i what I
wanted to confirm whether we run kube on mac(Unix)


Reply to this email directly or view it on GitHub
#5397 (comment)
.

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

@brendanburns can we apply both the PRs.

@brendandburns
Copy link
Contributor Author

fine with me to apply both.

On Thu, Mar 12, 2015 at 2:25 PM, sub-mod notifications@github.com wrote:

@brendanburns https://github.com/brendanburns can we apply both the PRs.


Reply to this email directly or view it on GitHub
#5397 (comment)
.

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

@satnam6502 fyi

@satnam6502
Copy link
Contributor

OK, merging.

satnam6502 added a commit that referenced this pull request Mar 12, 2015
Fix tests on OS X by re-introducing the old choose host interface
@satnam6502 satnam6502 merged commit b5082b2 into kubernetes:master Mar 12, 2015
@markturansky
Copy link
Contributor

@brendanburns Proxy still fails on OS X. Would you like a PR for it? This PR fixes the unit tests successfully.

This is my /tmp/kube-proxy.log:

I0312 18:36:46.642972   48203 util.go:410] Choosing interface en0 for from-host portals
I0312 18:36:46.643077   48203 util.go:415] Interface en0 = fe80::82e6:50ff:fe0a:981e/64
I0312 18:36:46.643093   48203 proxier.go:327] Setting Proxy IP to fe80::82e6:50ff:fe0a:981e
I0312 18:36:46.643103   48203 proxier.go:328] Initializing iptables
W0312 18:36:46.643164   48203 iptables.go:196] Error checking iptables version, assuming version at least 1.4.11: %vexec: "iptables": executable file not found in $PATH
I0312 18:36:46.643177   48203 iptables.go:186] running iptables -C [PREROUTING -t nat -j KUBE-PROXY]
W0312 18:36:46.643692   48203 iptables.go:196] Error checking iptables version, assuming version at least 1.4.11: %vexec: "iptables": executable file not found in $PATH
I0312 18:36:46.643709   48203 iptables.go:186] running iptables -C [OUTPUT -t nat -j KUBE-PROXY]
I0312 18:36:46.643744   48203 iptables.go:186] running iptables -F [KUBE-PROXY -t nat]
I0312 18:36:46.643790   48203 iptables.go:186] running iptables -X [KUBE-PROXY -t nat]
I0312 18:36:46.643835   48203 iptables.go:186] running iptables -N [KUBE-PORTALS-CONTAINER -t nat]
E0312 18:36:46.643875   48203 proxier.go:333] Failed to initialize iptables: error creating chain "KUBE-PORTALS-CONTAINER": exec: "iptables": executable file not found in $PATH: 
F0312 18:36:46.643887   48203 server.go:81] failed to create proxier, aborting

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

it is choosing ipv6 IP ,
@markturansky pls help me understand when u use boot2docker in mac it basically creates a VM right ? If yes I think /proc should be on that VM (I guess it is an ubuntu VM.)

@markturansky
Copy link
Contributor

I'll make a new PR will all my steps, logs, etc.

@markturansky
Copy link
Contributor

No need. There's still this open issue with services on OS X: #2170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants