Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create S3 bucket in known region (default to us-east-1) #5381

Merged
merged 1 commit into from
Mar 18, 2015

Conversation

justinsb
Copy link
Member

Buckets are globally named, so we want a single bucket for all our regions.

us-east-1 is the canonical choice.

@jacobkiers
Copy link

Regulatory reasons or compliance may compel one to only store data in a specific region. S3 enables this, because even though S3-buckets are globally named, the underlying storage is per-region. Therefore it would be great if the possibility remains to specify it.

Would you please consider this?

Using us-east-1 as a default is totally fine, of course.

@a-robinson a-robinson self-assigned this Mar 12, 2015
@a-robinson
Copy link
Contributor

Justin, would you be opposed to adding it as another config parameter in config-default.sh and config-test.sh?

@justinsb
Copy link
Member Author

Not at all... working on it now!

LMK if any objections to AWS_S3_REGION. (I think it needs to be a different default from the compute, because of the global namespacing)

@a-robinson
Copy link
Contributor

AWS_S3_REGION sounds good to me

@justinsb
Copy link
Member Author

This is conflicting with #5376. Whichever merges first, I'll sort out the gitmess :-)

@jacobkiers
Copy link

AWS_S3_REGION is fine with me too. My only concern was being able to specify it.

@a-robinson
Copy link
Contributor

Well neither one is currently mergable according to github, so you may have to sort out two git messes :)

@justinsb justinsb force-pushed the aws_s3_in_us_east branch 2 times, most recently from 1c29082 to 2435c96 Compare March 13, 2015 21:56
Buckets are globally named, so we want a single bucket for all our regions.
@justinsb justinsb force-pushed the aws_s3_in_us_east branch from 2435c96 to 2413d25 Compare March 16, 2015 15:37
@justinsb justinsb changed the title Always create S3 bucket in us-east-1 Create S3 bucket in known region (default to us-east-1) Mar 16, 2015
@justinsb
Copy link
Member Author

I'm not sure what causes a notification in github, so I'm adding a comment in case this has just been overlooked. I have rebased so this should now be mergeable.

@a-robinson
Copy link
Contributor

Yeah, I'm sorry, Github either doesn't notify reviewers of new commits or my account has been misconfigured for as long as I can remember. Thanks for pinging me.

a-robinson added a commit that referenced this pull request Mar 18, 2015
Create S3 bucket in known region (default to us-east-1)
@a-robinson a-robinson merged commit 2537665 into kubernetes:master Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants