Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #50673 #52962

Merged
merged 2 commits into from
Oct 17, 2017
Merged

Automated cherry pick of #50673 #52962

merged 2 commits into from
Oct 17, 2017

Conversation

clement-buchart
Copy link
Contributor

@clement-buchart clement-buchart commented Sep 25, 2017 •
edited by wojtek-t
Loading

Cherry pick of #50673 on release-1.7.

#50673: Use cloud environment to instantiate client

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @clement-buchart. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 25, 2017
@k8s-github-robot k8s-github-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 25, 2017
@clement-buchart clement-buchart mentioned this pull request Sep 25, 2017
Merged
@k8s-github-robot k8s-github-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 25, 2017
@andyzhangx
Copy link
Member

@brendanburns

@andyzhangx
Copy link
Member

@feiskyer

@feiskyer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 28, 2017
@feiskyer
Copy link
Member

LGTM

@andyzhangx
Copy link
Member

/test pull-kubernetes-unit

@clement-buchart
Copy link
Contributor Author

/retest

@andyzhangx andyzhangx mentioned this pull request Sep 28, 2017
Closed
@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-gce-bazel

3 similar comments
@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-gce-bazel

@clement-buchart
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-bazel

@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-gce-bazel

@djsly
Copy link
Contributor

djsly commented Oct 3, 2017

Looking forward to this fix. Need AzureSetorage in Germany. Currently running 1.7.5.
Thanks Guys!

@mikedanese
Copy link
Member

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2017
@mikedanese
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-gce-bazel

@djsly
Copy link
Contributor

djsly commented Oct 5, 2017

this didn't make it to 1.7.8 correct? :(

@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-gce-bazel

@mikedanese
Copy link
Member

/retest

1 similar comment
@clement-buchart
Copy link
Contributor Author

/retest

@andyzhangx andyzhangx mentioned this pull request Oct 9, 2017
Closed
@clement-buchart
Copy link
Contributor Author

Tests are finally OK.
May this be merged ?

@andyzhangx
Copy link
Member

@jdumars could you approve, thx

@jdumars
Copy link
Member

jdumars commented Oct 16, 2017

@andyzhangx @wojtek-t is the patch manager for 1.7 and will need to approve this. I am fine with it, but do not have the final say.

@wojtek-t
Copy link
Member

@clement-buchart - I'm fine with the cherrypick, but please add a user-friendly release note to the original PR (desribe the bug this change is fixing)

@andyzhangx
Copy link
Member

@clement-buchart pls add support German cloud for azure disk mount feature in Release note

@wojtek-t wojtek-t added this to the v1.7 milestone Oct 17, 2017
@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 17, 2017
@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clement-buchart, mikedanese, wojtek-t

Associated issue: 50673

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 17, 2017 •
edited
Loading

@clement-buchart: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel a26744f link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 7da1b98 into kubernetes:release-1.7 Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikedanese mikedanese

@wojtek-t wojtek-t

@jszczepkowski jszczepkowski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
10 participants
@clement-buchart @k8s-ci-robot @andyzhangx @feiskyer @djsly @mikedanese @jdumars @wojtek-t @k8s-github-robot @jszczepkowski