Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version #52941

Closed
wants to merge 1 commit into from
Closed

Bump version #52941

wants to merge 1 commit into from

Conversation

amitkumarj441
Copy link
Contributor

@amitkumarj441 amitkumarj441 commented Sep 23, 2017 •
edited
Loading

Signed-off-by: Amit Kumar Jaiswal amitkumarj441@gmail.com

What this PR does / why we need it:
This PR bump version for addition of CoreDNS 011

Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
Fixes kubernetes/kubeadm#446

Special notes for your reviewer:

Release note:

NONE

/cc @chrisohaver

@amitkumarj441
Update version
3dc9449 
Signed-off-by: Amit Kumar Jaiswal <amitkumarj441@gmail.com>
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @amitkumarj441. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amitkumarj441
We suggest the following additional approver: errordeveloper

Assign the PR to them by writing /assign @errordeveloper in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 23, 2017
liggitt
liggitt reviewed Sep 23, 2017
View reviewed changes
cmd/kubeadm/app/phases/addons/dns/versions.go
@@ -26,15 +26,15 @@ const (

// GetKubeDNSVersion returns the right kube-dns version for a specific k8s version
func GetKubeDNSVersion(kubeVersion *version.Version) string {
// v1.7.0+ uses 1.14.4, just return that here
// v1.8.0+ uses 1.14.4, just return that here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment doesn't match code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt Here is one follow-up PR for code.

liggitt
liggitt reviewed Sep 23, 2017
View reviewed changes
cmd/kubeadm/app/phases/addons/dns/versions.go
// In the future when the kube-dns version is bumped at HEAD; add conditional logic to return the right versions
// Also, the version might be bumped for different k8s releases on the same branch
return kubeDNSv170AndAboveVersion
}

// GetKubeDNSManifest returns the right kube-dns YAML manifest for a specific k8s version
func GetKubeDNSManifest(kubeVersion *version.Version) string {
// v1.7.0+ has only one known YAML manifest spec, just return that here
// v1.8.0+ has only one known YAML manifest spec, just return that here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, this change doesn't look right

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2017
@k8s-github-robot
Copy link

@amitkumarj441 PR needs rebase

@timothysc timothysc removed their assignment Oct 18, 2017
@timothysc
Copy link
Member

timothysc commented Oct 18, 2017 •
edited
Loading

Yeah the PR is incorrect, closing.
The original statement that @luxas made was correct.

@timothysc timothysc closed this Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

Assignees

@lukemarsden lukemarsden

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to use CoreDNS instead of KubeDNS in v1.9
6 participants
@amitkumarj441 @k8s-ci-robot @k8s-github-robot @timothysc @liggitt @lukemarsden