Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to load volume plugins for #52048 #52049

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Fix failure to load volume plugins for #52048 #52049

merged 1 commit into from
Nov 23, 2017
+6 −28

Conversation

cheftako
Copy link
Member

@cheftako cheftako commented Sep 6, 2017

Currently we have two plugin managers.
However one of them limits the cloud plugins it loads.
This means that if cloud provider is set to external the plugins will
not be loaded in that plugin manager. However they will be loaded in
the other instance of the plugin manager. So it does not actually save
us anything. It does hamper the efforts to actually get stage 1
separation working.

What this PR does / why we need it: It allows the plugins be found for the cloud providers working on stage 1 separation.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #52048

Special notes for your reviewer:

Release note:

@cheftako
Fix failure to load volume plugins for kubernetes#52048
7733f5a 
Currently we have two plugin managers.
However one of them limits the cloud plugins it loads.
This means that if cloud provider is set to external the plugins will
not be loaded in *that* plugin manager. However they will be loaded in
the other instance of the plugin manager. So it does not actually save
us anything. It does hamper the efforts to actually get stage 1
separation working.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 6, 2017
@cheftako
Copy link
Member Author

cheftako commented Sep 6, 2017

/assign wlan0

@liggitt liggitt assigned saad-ali and unassigned liggitt Sep 7, 2017
@liggitt liggitt added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Sep 7, 2017
@saad-ali
Copy link
Member

This seems fine to me. I don't think having the volume manager report all the volume plugins should be a problem
@verult can you PTAL, verify, and LGTM.

/approve

@verult
Copy link
Contributor

verult commented Sep 12, 2017

cc @jsafrane who authored the check

@verult
Copy link
Contributor

verult commented Sep 12, 2017

Here's the relevant discussion. Sounds like it was a safety check that may not be necessary.
#29006 (comment)

@jsafrane
Copy link
Member

Yes, it's a safety check. LGTM.

Just FYI, users will see different errors now - if someone uses AWS EBS volume on GCE, before this PR the user got something like "unknown plugin kubernetes.io/aws-ebs", now the user gets "Failed to get AWS Cloud Provider. GetCloudProvider returned %v instead". Not a big deal IMO.

@jsafrane
Copy link
Member

/assign

@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2017
@jsafrane
Copy link
Member

/assign @deads2k @lavalamp
for approval

@deads2k deads2k added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. status/approved-for-milestone labels Nov 20, 2017
@deads2k deads2k added this to the v1.9 milestone Nov 20, 2017
@deads2k
Copy link
Contributor

deads2k commented Nov 20, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, deads2k, jsafrane, saad-ali

Associated issue: 52048

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. milestone/incomplete-labels labels Nov 20, 2017
@enisoc enisoc added the kind/bug Categorizes issue or PR as related to a bug. label Nov 21, 2017
@k8s-github-robot k8s-github-robot removed this from the v1.9 milestone Nov 22, 2017
@enisoc enisoc added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed milestone/removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 23, 2017
@enisoc enisoc added this to the v1.9 milestone Nov 23, 2017
@cblecker
Copy link
Member

/test pull-kubernetes-e2e-gce

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@cheftako @deads2k @jlowdermilk @jsafrane @lavalamp @saad-ali @wlan0

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/storage: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 04d1fcc into kubernetes:master Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

@wlan0 wlan0

@jsafrane jsafrane

@j3ffml j3ffml

@deads2k deads2k

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Failure to load some of the volume plugins when cloud set to external.