Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating labels.md and design/labels.md #5189

Merged
merged 1 commit into from
Mar 11, 2015
Merged

updating labels.md and design/labels.md #5189

merged 1 commit into from
Mar 11, 2015
+76 −111

Conversation

sdminonne
Copy link
Contributor

@bgrant0607 @smarterclayton thanks to have a look

@bgrant0607 bgrant0607 self-assigned this Mar 9, 2015
bgrant0607
bgrant0607 reviewed Mar 10, 2015
View reviewed changes
docs/labels.md
The set based label selector is a general form of equality since `environment=production` is equivalent to `environment in (production)`; similarly for `!=` and `notin`.

Set based requirements can be mixed with equality based requirements. For example: `partition,environment!=qa`.


LIST and WATCH operations may specify label selectors to filter the sets of objects returned using a query parameter: `?labels=key1%3Dvalue1,key2%3Dvalue2,...`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend this example to illustrate the expanded query syntax.

@bgrant0607
Copy link
Member

Thanks @sdminonne.

The 2 labels docs were originally a single doc. There's still a lot of overlap. What do you think about re-merging them? There's really just one sentence in the design doc that's implementation-oriented rather than usage-oriented.

@sdminonne
Copy link
Contributor Author

@bgrant0607 working on this. Need few hours to come back.

@bgrant0607
Copy link
Member

Thanks.

@sdminonne sdminonne force-pushed the updating_labels_md branch from db8dbfb to ead073d Compare March 11, 2015 16:36
@sdminonne
Copy link
Contributor Author

@bgrant0607 PTAL

Hope it's better now.

bgrant0607
bgrant0607 reviewed Mar 11, 2015
View reviewed changes
docs/labels.md
@@ -1,9 +1,8 @@
# Labels

_Labels_ are key/value pairs that are attached to objects, such as pods.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add after this sentence:

Labels are intended to be used to specify identifying attributes of objects that are meaningful and relevant to users, but which do not directly imply semantics to the core system.

@bgrant0607
Copy link
Member

Thanks a lot. I made a few more suggestions but I think this will be good once they're done. After you make the changes, please squash your commits and comment on the PR.

@sdminonne sdminonne force-pushed the updating_labels_md branch from ead073d to 3e6472f Compare March 11, 2015 22:30
@sdminonne
Copy link
Contributor Author

@bgrant0607, squashed and rebased. PTAL.

@bgrant0607
Copy link
Member

Perfect!

bgrant0607 added a commit that referenced this pull request Mar 11, 2015
@bgrant0607
Merge pull request #5189 from sdminonne/updating_labels_md
f15cf12 
updating labels.md and design/labels.md
@bgrant0607 bgrant0607 merged commit f15cf12 into kubernetes:master Mar 11, 2015
@sdminonne sdminonne deleted the updating_labels_md branch September 29, 2015 09:36
@bgrant0607 bgrant0607 mentioned this pull request Apr 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdminonne @bgrant0607 @googlebot