Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discover valid resources for kubectl instead of current hard-coded way #51865

Closed
wants to merge 2 commits into from
Closed

discover valid resources for kubectl instead of current hard-coded way #51865

wants to merge 2 commits into from

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Sep 3, 2017 •
edited
Loading

What this PR does / why we need it:
Per discussion and discussion.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
xref #51089

Special notes for your reviewer:
/assign @liggitt @caesarxuchao

Release note:

discover valid resources for kubectl instead of current hard-coded way

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 3, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 3, 2017
@dixudx dixudx mentioned this pull request Sep 3, 2017
Closed
@dixudx dixudx force-pushed the kubectl_discover_valid_resources branch from ae06750 to af2d792 Compare September 3, 2017 08:10
@xiangpengzhao
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 3, 2017
@dixudx dixudx changed the title discovery valid resources for kubectl instead of current hard-coded way discover valid resources for kubectl instead of current hard-coded way Sep 3, 2017
@xiangpengzhao
Copy link
Contributor

It's strange this PR doesn't have a release note label. Maybe bot is sleeping...

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dixudx
We suggest the following additional approver: liggitt

Assign the PR to them by writing /assign @liggitt in a comment when ready.

Associated issue: 51089

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 3, 2017
@xiangpengzhao
Copy link
Contributor

Hmmm, my comment wakes it up.

@dixudx dixudx force-pushed the kubectl_discover_valid_resources branch from af2d792 to 1ead29a Compare September 3, 2017 14:48
@dixudx
Copy link
Member Author

dixudx commented Sep 3, 2017

/assign @mengqiy

PTAL. Thanks.

@liggitt
Copy link
Member

liggitt commented Sep 3, 2017

We cannot require server contact to display command help. A separate command to display valid resources (like #42873) would be best, and we can reference that command from the help text

@liggitt
Copy link
Member

liggitt commented Sep 3, 2017

Also, the factory is not usable for client building prior to command invocation (not all flags that affect server contact have not been parsed yet), and making calls in constructing the command mean those calls will be made for every invocation of kubectl that runs any command, not just this one.

@liggitt liggitt closed this Sep 3, 2017
@k8s-ci-robot
Copy link
Contributor

@dixudx: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel 1ead29a link /test pull-kubernetes-e2e-gce-bazel
pull-kubernetes-e2e-gce-etcd3 1ead29a link /test pull-kubernetes-e2e-gce-etcd3
pull-kubernetes-e2e-gce-gpu 1ead29a link /test pull-kubernetes-e2e-gce-gpu
pull-kubernetes-federation-e2e-gce 1ead29a link /test pull-kubernetes-federation-e2e-gce
pull-kubernetes-kubemark-e2e-gce 1ead29a link /test pull-kubernetes-kubemark-e2e-gce
pull-kubernetes-e2e-kops-aws 1ead29a link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-unit 1ead29a link /test pull-kubernetes-unit
pull-kubernetes-bazel-test 1ead29a link /test pull-kubernetes-bazel-test
pull-kubernetes-verify 1ead29a link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xiangpengzhao
Copy link
Contributor

xref: #51324

@dixudx dixudx deleted the kubectl_discover_valid_resources branch September 9, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

@mengqiy mengqiy

@caesarxuchao caesarxuchao

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dixudx @k8s-ci-robot @xiangpengzhao @k8s-github-robot @liggitt @mengqiy @caesarxuchao