Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: default image format to v2 instead of deprecated v1 #51574

Merged
merged 1 commit into from
Sep 1, 2017
Merged

rbd: default image format to v2 instead of deprecated v1 #51574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/volume/rbd/rbd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ func (r *rbdVolumeProvisioner) Provision() (*v1.PersistentVolume, error) {
adminSecretNamespace := rbdDefaultAdminSecretNamespace
secretName := ""
secret := ""
imageFormat := rbdImageFormat1
imageFormat := rbdImageFormat2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require any new packages or configuration to change? Could this break existing users on upgrade?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative -- RBD v2 images have been supported for 5+ years and krbd/librbd can transparently open v1 and v2 images. The only thing changing here is that newly created images, by default, will use the v2 on-disk format.

fstype := ""

for k, v := range r.options.Parameters {
Expand Down