Skip "Simple pod should support exec through kubectl proxy" test #51047
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/XS
|
cc @kubernetes/sig-cli-bugs @kubernetes/sig-api-machinery-bugs |
k8s-ci-robot
added
sig/cli
|
Some of the discussion is also in #50775 |
|
Let's make sure the test is skipped in GKE and everything goes well, /test pull-kubernetes-e2e-gke |
|
cc @liggitt |
|
/unassign smarterclayton |
|
At least it didn't fail on that test. /test pull-kubernetes-e2e-gke This is disabling a feature added by @smarterclayton recently, I want to be sure he acknowledges that. /assign smarterclayton |
|
/test pull-kubernetes-e2e-gke |
That's actually not the root cause. The root cause is that |
|
@liggitt I updated the description |
test/e2e/kubectl/kubectl.go
Outdated
| // TODO(kubernetes/kubernetes#50466): This test | ||
| // fails in GKE because of the Transport layer | ||
| // used. | ||
| framework.SkipIfProviderIs("gke") |
There was a problem hiding this comment.
it's not the provider that is the issue, it's the kubectl auth mechanism (bearer token auth will fail with the feature as it is implemented currently).
|
Right, but right now we want the test to pass. |
|
I'll update the comment |
As reported in kubernetes#50466, this test doesn't work in GKE because the transport layer doesn't work with dialing. As the feature that is broken in GKE is new and didn't work before, it is safe to juste ignore the test and consider the feature as "still not working" in GKE.
apelisse
force-pushed
the
remove-gke-test
branch
from
486326f to
3bc6cea
Compare
|
/approve |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@liggitt Good point. Lets disable this test, and reenable it once the underlying issue has been fixed. |
k8s-github-robot
added
the
approved
|
/approve #50466 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, pwittrock Associated issue: 50466 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/priority failing-test |
k8s-ci-robot
added
the
kind/failing-test
|
/retest |
|
Fix is in #51168 but will probably be a day or so to test. |
|
@smarterclayton SGTM. WDYT of reenabling this test in that PR. |
|
@apelisse: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
Automatic merge from submit-queue |
As reported in #50466,
this test doesn't work in GKE because it uses a bearer token and the feature only works with client certs.
As the feature that is broken in GKE is new and didn't work before, it
is safe to juste ignore the test and consider the feature as "still not
working" in GKE.
What this PR does / why we need it: Fixes the broken test in https://k8s-testgrid.appspot.com/release-master-blocking#gke
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): works-around #50466Special notes for your reviewer:
Release note: