Refactor Kubelets syncPod function by wrapping some functionalities into separate functions #5094
Conversation
| return true | ||
| } | ||
|
|
||
| func (kl *Kubelet) getPodInfraContainer(podFullName string, uid types.UID, |
There was a problem hiding this comment.
Lets document this method (mainly worried about the return values).
|
Thanks for splitting up @gmarek! Only minor comments. |
|
Also please run the e2e tests when you have time :) |
|
Heads up btw: Will need a rebase after the PRs that went in today |
|
Looks good! Can you squash your commits before we merge? Have you had a chance to run the e2e tests btw? |
|
Squashed. I run them yesterday and there were even less red that ones on the head, but that's probably a flake. I'm running it right now, so I'll probably be able to tell which fail in an hour or so. |
|
@gmarek thanks! let me know and I'll merge. If you need to head out let me know and I can run them. |
|
I already left, but running tests do not use a lot of 'cpu time'. Plus they are already running. |
|
e2e is green. |
|
Thanks @gmarek! Merging. |
Refactor Kubelets syncPod function by wrapping some functionalities into separate functions
It's related to #4731. I chose semantically neutral parts of WIP PR #5022