Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #49316 #49330 #49339

Merged
merged 2 commits into from
Jul 21, 2017
Merged

Automated cherry pick of #49316 #49330 #49339

merged 2 commits into from
Jul 21, 2017

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Jul 20, 2017 •
edited
Loading

Cherry pick of #49316 #49330 on release-1.7.

#49316: Use custom port for node-problem-detector
#49330: Bump up minNodesHealthCheckVersion in gce_healthcheck due to known issues

Release note:

- Use port 20256 for node-problem-detector in standalone mode.
- GCE Cloud Provider: New created LoadBalancer type Service will have health checks for nodes by default if all nodes have version >= v1.7.2.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jul 20, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Jul 20, 2017

/assign @wojtek-t
These two PRs need to be cherrypicked into 1.7 to fix #49263. Thanks!

cc @ajitak @nicksardo @bowei @thockin

@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 21, 2017
@yujuhong yujuhong added this to the v1.7 milestone Jul 21, 2017
@ajitak
Copy link
Contributor

ajitak commented Jul 21, 2017

/test pull-kubernetes-e2e-gce-etcd3

@bowei
Copy link
Member

bowei commented Jul 21, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2017
@bowei
Copy link
Member

bowei commented Jul 21, 2017

@wojtek-t approval

@ajitak
Copy link
Contributor

ajitak commented Jul 21, 2017

/test pull-kubernetes-e2e-gce-etcd3

1 similar comment
@MrHohn
Copy link
Member Author

MrHohn commented Jul 21, 2017

/test pull-kubernetes-e2e-gce-etcd3

@bowei
Copy link
Member

bowei commented Jul 21, 2017

/retest

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 21, 2017
@wojtek-t
Copy link
Member

Merging manually to speed up the release.

@wojtek-t wojtek-t merged commit 66bf0de into kubernetes:release-1.7 Jul 21, 2017
@wojtek-t
Copy link
Member

/approve

@wojtek-t wojtek-t added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, bowei, wojtek-t

Associated issue: 49316

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@MrHohn MrHohn deleted the automated-cherry-pick-of-#49316-#49330-upstream-release-1.7 branch October 5, 2017 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bowei bowei

@j3ffml j3ffml

@roberthbailey roberthbailey

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
9 participants
@MrHohn @ajitak @bowei @wojtek-t @k8s-github-robot @j3ffml @roberthbailey @yujuhong @k8s-ci-robot