Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround tcpv4-only-systems connect issue in test #48683

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Workaround tcpv4-only-systems connect issue in test #48683

merged 1 commit into from
Jul 10, 2017
+5 −1

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jul 10, 2017

Fixes #47304.

Workarounds golang/go#18806 (fixed in Go 1.9+).

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 10, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2017
@sttts sttts added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/P0 and removed release-note-label-needed labels Jul 10, 2017
@sttts
Copy link
Contributor Author

sttts commented Jul 10, 2017

/cc @CaoShuFeng ptal

@k8s-ci-robot
Copy link
Contributor

@sttts: GitHub didn't allow me to request PR reviews from the following users: CaoShuFeng, ptal.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @CaoShuFeng ptal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts sttts added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 10, 2017
@sttts
Copy link
Contributor Author

sttts commented Jul 10, 2017

/retest

1 similar comment
@sttts
Copy link
Contributor Author

sttts commented Jul 10, 2017

/retest

@sttts
Copy link
Contributor Author

sttts commented Jul 10, 2017

@smarterclayton approved?

@sttts sttts mentioned this pull request Jul 10, 2017
Merged
@sttts
Copy link
Contributor Author

sttts commented Jul 10, 2017

/retest

@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, wojtek-t

Associated issue: 47304

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2017
@luxas
Copy link
Member

luxas commented Jul 10, 2017

Thanks @sttts!

@luxas
Copy link
Member

luxas commented Jul 10, 2017

@wojtek-t May have to hand-merge as kops seems to timeout all the time...

@sttts sttts mentioned this pull request Jul 10, 2017
Merged
@wojtek-t
Copy link
Member

/test pull-kubernetes-federation-e2e-gce

@sttts
Copy link
Contributor Author

sttts commented Jul 10, 2017

/test pull-kubernetes-e2e-kops-aws

@CaoShuFeng
Copy link
Contributor

Test OK in my environment.
Thanks.

@wojtek-t
Copy link
Member

/test pull-kubernetes-federation-e2e-gce

@wojtek-t
Copy link
Member

@sttts - are you sure that those failing federation-e2e jobs are not related to your change?

@sttts
Copy link
Contributor Author

sttts commented Jul 10, 2017

@wojtek-t my change is local to the TestCertsTLS unit test, as far as I see.

@wojtek-t
Copy link
Member

@sttts - oops, yeah sorry, you're right.
I'm tired with rekicking it again and again. I'm merging it manually to fix the failing unit test.

@wojtek-t wojtek-t merged commit 0744964 into kubernetes:master Jul 10, 2017
@sttts
Copy link
Contributor Author

sttts commented Jul 10, 2017

@wojtek-t thanks!

The federation test doesn't look healthy since Friday.

@k8s-ci-robot
Copy link
Contributor

@sttts: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce 7ffa2fa link /test pull-kubernetes-federation-e2e-gce
pull-kubernetes-e2e-kops-aws 7ffa2fa link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gmarek gmarek mentioned this pull request Jul 11, 2017
Merged
@caesarxuchao caesarxuchao added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Jul 11, 2017
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@caesarxuchao caesarxuchao added this to the v1.7 milestone Jul 11, 2017
wojtek-t added a commit that referenced this pull request Jul 12, 2017
@wojtek-t
Merge pull request #48764 from gmarek/automated-cherry-pick-of-#48683…
3af77ff 
…-upstream-release-1.7

Automated cherry pick of #48683
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

This was referenced Jul 12, 2017
Merged
Merged
enisoc added a commit that referenced this pull request Jul 13, 2017
@enisoc
Merge pull request #48844 from enisoc/automated-cherry-pick-of-#48683…
9cf8e40 
…-upstream-release-1.6

Automated cherry pick of #48683
@saad-ali saad-ali mentioned this pull request Jul 13, 2017
Merged
saad-ali added a commit that referenced this pull request Jul 13, 2017
@saad-ali
Merge pull request #48903 from saad-ali/automated-cherry-pick-of-#486…
7d4ee55 
…83-upstream-release-1.5

Automated cherry pick of #48683 upstream release 1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caesarxuchao caesarxuchao

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

unit test TestCertsTLS fails when IPV6 is disabled
10 participants
@sttts @k8s-ci-robot @wojtek-t @k8s-github-robot @luxas @CaoShuFeng @k8s-cherrypick-bot @caesarxuchao @irfanurrehman @csbell