Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Heapster to v1.4.0 #48205

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Conversation

piosz
Copy link
Member

@piosz piosz commented Jun 28, 2017

Bumped Heapster to v1.4.0.
More details about the release https://github.com/kubernetes/heapster/releases/tag/v1.4.0

follow up #47961
The release candidate v1.4.0-beta.0 turned out to be stable.

@piosz piosz added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 28, 2017
@piosz piosz added this to the v1.7 milestone Jun 28, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2017
@piosz piosz added cherrypick-candidate and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2017
@piosz
Copy link
Member Author

piosz commented Jun 28, 2017

/test pull-kubernetes-e2e-kops-aws

@piosz
Copy link
Member Author

piosz commented Jun 28, 2017

@dchen1107 @caesarxuchao would be great to include this in 1.7 release

@DirectXMan12
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, piosz

Associated issue: 47961

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48004, 48205, 48130, 48207)

@k8s-github-robot k8s-github-robot merged commit a17f15a into kubernetes:master Jun 28, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@caesarxuchao
Copy link
Member

It looks like k8s-cherrypick-bot is mistaken.

@caesarxuchao
Copy link
Member

caesarxuchao commented Jun 28, 2017

@piosz Is v1.4.0 the same as v1.4.0-beta.0?

@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@caesarxuchao
Copy link
Member

@foxish @cjwagner could you take a look at the cherrypick bot? The commit is not in release-1.7 but the bot thinks it is.

@foxish
Copy link
Contributor

foxish commented Jun 28, 2017

/cc @eparis, who is the most familiar with the cherrypick bot.

@piosz piosz deleted the heapster-1.4 branch June 28, 2017 19:39
@piosz
Copy link
Member Author

piosz commented Jun 28, 2017

@caesarxuchao there was a tiny bug fix to SD sink which is used in Kubernetes + migration to a new version of ES which isn't used in Kubernetes at all.

@caesarxuchao
Copy link
Member

Ok. I'm going to batch cherrypick it.

@caesarxuchao
Copy link
Member

cc @dchen1107

@caesarxuchao caesarxuchao added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Jun 28, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants