-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update addons with upstream CVE fixes #47877
Conversation
@@ -46,11 +46,11 @@ spec: | |||
containers: | |||
# TODO: Add resources in 1.8 | |||
- name: event-exporter | |||
image: gcr.io/google-containers/event-exporter:v0.1.0 | |||
image: gcr.io/google-containers/event-exporter:v0.1.0-r2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where this is even used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For kube-dns: May want to bump up KubeDNSVersion
in https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/phases/addons/manifests.go#L99 as well.
@MrHohn thanks! done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM for kube-dns
/lgtm |
/lgtm |
/retest |
/assign @luxas @mikedanese |
Thanks! /approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, crassirostris, dnardo, ixdy, mikedanese Associated issue: 47386 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue |
* Updates kube-dns to latest kube-dns was pretty out of date... latest version includes CVE fixes [1]. Slightly modified from [2] to work here. Removed serviceAccountName and strategy block. Tested with the following command: ``` kubectl run -i --tty testdns --rm --restart=Never --image=busybox --command -- nslookup kubernetes.default ``` [1] kubernetes/kubernetes#47877 [2] https://github.com/kubernetes/kubernetes/tree/e633a1604f00908a1dcc898b206c3404db4d82ed/cluster/addons/dns * Removes irrelevant kube-dns template comments
What this PR does / why we need it: refreshes the kube-dns, metadata-proxy, and fluentd-gcp, event-exporter, prometheus-to-sd, and ip-masq-agent addons with new base images containing fixes for the following vulnerabilities:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #47386 (yay!)Special notes for your reviewer:
Release note:
/assign @bowei @MrHohn @Q-Lee @crassirostris @dnardo
/cc @dchen1107 @timstclair