Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shiywang to sig-cli help out review code #47587

Merged
merged 1 commit into from
Aug 15, 2017

Conversation

shiywang
Copy link
Contributor

@pwittrock @fabianofranz @adohe @mengqiy I would like to help team review pr : )

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 15, 2017
@shiywang
Copy link
Contributor Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@jbeda
Copy link
Contributor

jbeda commented Jun 15, 2017

/approve no-issue

@kubernetes kubernetes deleted a comment from k8s-github-robot Jun 15, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2017
@shiywang
Copy link
Contributor Author

/assign @pwittrock

@mengqiy
Copy link
Member

mengqiy commented Jun 15, 2017

@shiywang Can you help change my GH handle as well in this PR? I have change it from ymqytw to mengqiy.
https://github.com/kubernetes/kubernetes/pull/47587/files#diff-0de52d14f35759dfa67139f90c82bd7fR36

@shiywang
Copy link
Contributor Author

@mengqiy sure, done

@pwittrock
Copy link
Member

Thanks for the interest! Great the you are interested in doing reviews. How about we start by having you shadow / reverse shadow a number of PRs before automatically assigning them to you? I'll start assigning some substantial PRs for you to review. Lets leave this PR open, but please sort the GH handles.

@shiywang
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@shiywang
Copy link
Contributor Author

flag change && options changed:
#48751
#48684
#46546

validation compatibility between cli and api-server
#48433
#47962 (port range validation)
#48655 (deduce duplicate ingress ip with a map)
#48082

printer realted
#48807
#48022
#48033

bash zsh completion related:
#48270
#48553

minor fix, refactor code no feature added
#48595
#48079
#47675
#46510
#48572
#45645

translation
#46559

other bug fix
#45611
#41699
#48868

@pwittrock I think this is the list I've read the whole code and made my comments, there's still some swagger/openapi, client-discovery and strategic-merge-patch related pr I haven't take a look yet, I will take some time to learn those part of code asap.

@pwittrock
Copy link
Member

/approve

@pwittrock
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbeda, pwittrock, shiywang

Associated issue requirement bypassed by: jbeda

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49129, 50436, 50417, 50553, 47587)

@k8s-github-robot k8s-github-robot merged commit e0c3eaf into kubernetes:master Aug 15, 2017
@shiywang shiywang deleted the shiywang branch August 15, 2017 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants