-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shiywang to sig-cli help out review code #47587
Conversation
@k8s-bot pull-kubernetes-federation-e2e-gce test this |
/approve no-issue |
/assign @pwittrock |
@shiywang Can you help change my GH handle as well in this PR? I have change it from |
@mengqiy sure, done |
Thanks for the interest! Great the you are interested in doing reviews. How about we start by having you shadow / reverse shadow a number of PRs before automatically assigning them to you? I'll start assigning some substantial PRs for you to review. Lets leave this PR open, but please sort the GH handles. |
/test pull-kubernetes-e2e-kops-aws |
flag change && options changed: validation compatibility between cli and api-server printer realted bash zsh completion related: minor fix, refactor code no feature added translation other bug fix @pwittrock I think this is the list I've read the whole code and made my comments, there's still some swagger/openapi, client-discovery and strategic-merge-patch related pr I haven't take a look yet, I will take some time to learn those part of code asap. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbeda, pwittrock, shiywang Associated issue requirement bypassed by: jbeda The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest Review the full test history for this PR. |
Automatic merge from submit-queue (batch tested with PRs 49129, 50436, 50417, 50553, 47587) |
@pwittrock @fabianofranz @adohe @mengqiy I would like to help team review pr : )