-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "add gzip compression to GET and LIST requests" #47191
Conversation
This reverts commit fc650a5.
@k8s-bot pull-kubernetes-unit test this |
I wonder what would cause those tests to flake. Is there a way I can try to reproduce this locally? |
I wasn't able to pin it down, but some possible ideas:
for recreation... I would create a bunch of namespaces (50?) with some number of resources in them (including running pods to exercise graceful deletion loops), then delete them all at once and observe the namespace controller's behavior |
/lgtm cc/ @kubernetes/kubernetes-release-managers @foxish, the build cop |
e2e: |
unit test failure in https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/47191/pull-kubernetes-unit/35607/ is known flake (#42289) recommend merging this to fix the gce-e2e job |
@k8s-bot pull-kubernetes-unit test this |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, liggitt, mikedanese Associated issue: 47135 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
All tests are green. I am going to manually merge the pr for #47135 |
It sounds like CPU usage issue. gzip is not particularly cheap and thus we shouldn't enable it by default. |
xref #47135
This reverts commit fc650a5 added in #45666
After #45666 merged, namespace deletion started flaking significantly in e2e runs.
Disabling the gzip compression and running the problematic suite fixed the issue, though I'm still not sure why. Namespace deletion time dropped significantly with gzip disabled.