Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix standardFinalizers - add missing metav1.FinalizerDeleteDependents #46500

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Fix standardFinalizers - add missing metav1.FinalizerDeleteDependents #46500

merged 1 commit into from
Jun 2, 2017

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented May 26, 2017 •
edited by enisoc
Loading

What this PR does / why we need it:
It adds FinalizerDeleteDependents to standardFinalizers otherwise this finalizer is unusable because apiserver will fail validation because it is not fully qualified name - but it is a standard Kubernetes finalizer used by garbage collector but it can't be set.

It's sibling FinalizerOrphanDependents is already there. I suppose this is a bug because otherwise FinalizerDeleteDependents is unusable.

Fixes openshift/origin#14322
Might fix #45764

Not for the reviewer:
This same definition is also in staging. Does it get propagated to staging automatically? Editing the same file twice doesn't seem like the intended option.

Fix `Invalid value: "foregroundDeletion"` error when attempting to delete a resource.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @tnozicka. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 26, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels May 26, 2017
@tnozicka tnozicka mentioned this pull request May 26, 2017
Merged
@pwittrock pwittrock assigned yujuhong and unassigned pwittrock May 26, 2017
@pwittrock
Copy link
Member

@yujuhong kicking over to the node team

@caesarxuchao
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 30, 2017
@caesarxuchao
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 30, 2017
@caesarxuchao
Copy link
Member

You need to call the hack/update-staging-client-go.sh to update the staging code, otherwise the verification will fail. Since it's just one line, manually copy it would be easier.

@caesarxuchao caesarxuchao removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 30, 2017
@caesarxuchao
Copy link
Member

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 30, 2017
@caesarxuchao
Copy link
Member

I guess we didn't catch the bug because the finalizer is usually set via the DeleteOptions at the REST layer, which is not subject to validation.

@caesarxuchao caesarxuchao added the kind/bug Categorizes issue or PR as related to a bug. label May 30, 2017
@caesarxuchao caesarxuchao added this to the v1.7 milestone May 30, 2017
@caesarxuchao
Copy link
Member

/assign @lavalamp

@yujuhong yujuhong removed their assignment May 30, 2017
@tnozicka tnozicka force-pushed the fix-standard-finalizers branch from fcaf70e to 9ed01e4 Compare May 31, 2017 07:22
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2017
@caesarxuchao
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@lavalamp
Copy link
Member

lavalamp commented Jun 1, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, lavalamp, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2017
@tnozicka
Copy link
Contributor Author

tnozicka commented Jun 2, 2017

Flake #46853
@k8s-bot pull-kubernetes-e2e-kops-aws test this

@k8s-bot pull-kubernetes-federation-e2e-gce test this
@k8s-bot pull-kubernetes-verify test this

@0xmichalis
Copy link
Contributor

@k8s-bot pull-kubernetes-e2e-kops-aws test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this
@k8s-bot pull-kubernetes-verify test this

@caesarxuchao
Copy link
Member

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@caesarxuchao
Copy link
Member

@k8s-bot pull-kubernetes-verify test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@caesarxuchao
Copy link
Member

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 2, 2017 •
edited
Loading

@tnozicka: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 9ed01e4 link @k8s-bot pull-kubernetes-e2e-kops-aws test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46648, 46500, 46238, 46668, 46557)

@k8s-github-robot k8s-github-robot merged commit c97c353 into kubernetes:master Jun 2, 2017
@tnozicka tnozicka deleted the fix-standard-finalizers branch June 5, 2017 06:09
@tnozicka tnozicka mentioned this pull request Jun 5, 2017
Merged
@caesarxuchao caesarxuchao mentioned this pull request Jun 23, 2017
Closed
@dchen1107 dchen1107 mentioned this pull request Jun 23, 2017
Closed
@caesarxuchao caesarxuchao modified the milestones: v1.6, v1.7 Jun 23, 2017
@caesarxuchao
Copy link
Member

It's in 1.7, but need to be backported to 1.6.

@caesarxuchao caesarxuchao mentioned this pull request Jun 23, 2017
Merged
@caesarxuchao
Copy link
Member

Sent #47994.

@enisoc enisoc added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 26, 2017
k8s-github-robot pushed a commit that referenced this pull request Jun 26, 2017
Merge pull request #47994 from caesarxuchao/automated-cherry-pick-of-…
020412e 
…#46500-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #46500

Cherry pick of #46500 on release-1.6.

#46500: Fix standardFinalizers - add missing

Fix #47960
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@liggitt liggitt mentioned this pull request Nov 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.