Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Unit Test for PodList Printer #45877

Merged
merged 1 commit into from
Jun 8, 2017
Merged

add Unit Test for PodList Printer #45877

merged 1 commit into from
Jun 8, 2017

Conversation

zhangxiaoyu-zidif
Copy link
Contributor

Signed-off-by: zhangxiaoyu-zidif zhang.xiaoyu33@zte.com.cn

What this PR does / why we need it:
add Unit Test for PodList Printer

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 16, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels May 16, 2017
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 16, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @zhangxiaoyu-zidif. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@foxish
Copy link
Contributor

foxish commented May 16, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 16, 2017
@zhangxiaoyu-zidif
Copy link
Contributor Author

/assign @deads2k

@zhangxiaoyu-zidif
Copy link
Contributor Author

ping @deads2k

@deads2k
Copy link
Contributor

deads2k commented May 26, 2017

@fabianofranz do you want to try to enforce output stability like this? Doesn't seem like it will play nice with server-side get in the long run.

@zhangxiaoyu-zidif
Copy link
Contributor Author

@fabianofranz PTAL

@zhangxiaoyu-zidif
Copy link
Contributor Author

@deads2k could you show me an example about "server-side get" to refer. I will be thankful. =)

@deads2k
Copy link
Contributor

deads2k commented May 31, 2017

@deads2k could you show me an example about "server-side get" to refer. I will be thankful. =)

https://github.com/kubernetes/community/blob/a5c36ce33262d7b77b18acf7c4048d0febc2c6c7/contributors/design-proposals/server-get.md

@fabianofranz
Copy link
Contributor

@deads2k Yeah, won't play nicely with server-side get, but on the other hand we have already a number of places where we test the output like this, and I don't see client-side get going away anytime soon given client backwards compatibility. I'm ok with having this, sounds reasonable to you?

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2017
@deads2k deads2k removed their assignment Jun 1, 2017
@deads2k
Copy link
Contributor

deads2k commented Jun 1, 2017

I'm ok with having this, sounds reasonable to you?

Sure. I'll leave it with you.

@fabianofranz
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@falenn
Copy link

falenn commented Jun 1, 2017 via email

@calebamiles calebamiles modified the milestone: v1.7 Jun 2, 2017
@zhangxiaoyu-zidif
Copy link
Contributor Author

@k8s-bot pull-kubernetes-bazel test this
@k8s-bot pull-kubernetes-unit test this

@wojtek-t
Copy link
Member

wojtek-t commented Jun 4, 2017

@k8s-bot pull-kubernetes-unit test this
@k8s-bot pull-kubernetes-bazel test this

@zhangxiaoyu-zidif
Copy link
Contributor Author

@k8s-bot pull-kubernetes-bazel test this

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2017
@zhangxiaoyu-zidif
Copy link
Contributor Author

Because of #40848, I refactor my PR.

@zhangxiaoyu-zidif
Copy link
Contributor Author

Hi @fabianofranz , I need your lgtm label. Thanks.

@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2017
@zhangxiaoyu-zidif
Copy link
Contributor Author

Hi @fabianofranz , could you re-added the lgtm label? because I fix the PR since function interface changed.

@fabianofranz
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2017
@fabianofranz
Copy link
Contributor

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, zhangxiaoyu-zidif

Associated issue requirement bypassed by: fabianofranz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2017
@zhangxiaoyu-zidif
Copy link
Contributor Author

@k8s-bot pull-kubernetes-unit test this

@zhangxiaoyu-zidif
Copy link
Contributor Author

/retest

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@zhangxiaoyu-zidif
Copy link
Contributor Author

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45877, 46846, 46630, 46087, 47003)

@k8s-github-robot k8s-github-robot merged commit 41f6f9d into kubernetes:master Jun 8, 2017
@k8s-ci-robot
Copy link
Contributor

@zhangxiaoyu-zidif: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-etcd3 3ef73bd link @k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants