Use OS-specific libs when computing client User-Agent in kubectl, etc. #44622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nch. The original full PR kubernetes#44423 came after a large PR kubernetes#40777 that split /vendor/BUILD into hundreds of BUILD files. Thus PR 44423's version of rest/BUILD does not exist in the 1.6 release branch, and had to be tweaked here.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
do-not-merge
|
This change is |
|
can someone assign this to @enisoc please? |
|
change lgtm |
|
thanks @liggitt ! |
enisoc
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: enisoc, monopole
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue |
mikedanese
reviewed
Apr 18, 2017
| @@ -100,6 +102,42 @@ func TestSetKubernetesDefaultsUserAgent(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestAdjustVersion(t *testing.T) { | |||
| assert := assert.New(t) | |||
There was a problem hiding this comment.
Go style guide recommends against using assert libraries.
https://github.com/golang/go/wiki/CodeReviewComments#useful-test-failures
A table test would have worked effectively here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue 44419 in the release branch.
This PR is a patchable version of mainline PR #44423 for 1.6 release branch
The original full PR
#44423
came after a large PR
#40777
that split /vendor/BUILD into hundreds of BUILD files.
Thus PR 44423's version of rest/BUILD does not exist
in the 1.6 release branch, and had to be tweaked here.