Add monitoring instrumentation for the remaining HTTP handlers in the apiserver. #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ctx := api.WithNamespace(api.NewContext(), requestInfo.Namespace) | ||
|
|
||
| storage := h.storage[requestInfo.Resource] | ||
| if storage == nil { | ||
| notFound(w, req) | ||
| httpCode = http.StatusNotFound |
There was a problem hiding this comment.
this makes me slightly worries that in the future changes we'll forget to add this annotation
|
LGTM, only one forward-looking concern. Merging. |
vmarmol
added a commit
that referenced
this pull request
Feb 11, 2015
Add monitoring instrumentation for the remaining HTTP handlers in the apiserver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1625, follow up to #4272. cc @vmarmol
This is as far as I'm planning to go with instrumentation for the time being. I'll check in with folks more familiar with the master than me to see if they have suggestions for additional important metrics.