Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix orphaned pod & volume cleanup order. Volumes need to be unmounted before pod cleanup. #4093

Merged
merged 1 commit into from
Feb 4, 2015
Merged

Fix orphaned pod & volume cleanup order. Volumes need to be unmounted before pod cleanup. #4093

merged 1 commit into from
Feb 4, 2015

Conversation

chakri-nelluri
Copy link
Contributor

Fix orphaned pod & volume cleanup order. Volumes need to be unmounted before pod cleanup.

@a-robinson
Copy link
Contributor

Issue #4086

@brendandburns
Copy link
Contributor

LGTM, will merge in the AM.

@brendandburns brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. area/kubelet labels Feb 4, 2015
@brendandburns
Copy link
Contributor

Actually I don't see a CLA on file for you, can you fill one out as described in CONTRIBUTING.md

@chakri-nelluri
Copy link
Contributor Author

Thanks Brendan for checking.
Submitted corporate CLA yesterday evening to cla-submissions@google.com. It might be under review.

@thockin
Copy link
Member

thockin commented Feb 4, 2015

Change LGTM

@thockin thockin closed this Feb 4, 2015
@thockin thockin reopened this Feb 4, 2015
@thockin
Copy link
Member

thockin commented Feb 4, 2015

Why is the "Close and comment" button so close to the "Comment" button? :)

@dchen1107 dchen1107 added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 4, 2015
@brendandburns
Copy link
Contributor

Ok, yeah, the Corp SLA process is more manual and slower than the individual CLA process. I'll ping legal and see what the status is...

@brendandburns
Copy link
Contributor

Oops, I actually see it, my search was for datawise, not datawisesystems.

merging.

brendandburns added a commit that referenced this pull request Feb 4, 2015
@brendandburns
Merge pull request #4093 from nelcy/master
6e89752 
Fix orphaned pod & volume cleanup order. Volumes need to be unmounted before pod cleanup.
@brendandburns brendandburns merged commit 6e89752 into kubernetes:master Feb 4, 2015
@brendandburns brendandburns mentioned this pull request Feb 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

Labels
area/kubelet lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chakri-nelluri @a-robinson @brendandburns @thockin @dchen1107