Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/util: move httpstream to k8s.io/apimachinery #40605

Merged
merged 2 commits into from
Jan 29, 2017
Merged

pkg/util: move httpstream to k8s.io/apimachinery #40605

merged 2 commits into from
Jan 29, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 27, 2017

pick one commit from @sttts's pull #40426

This blocks some client-go splitting, so I'm picking it out and merging it separately. It's not my commit, so its not a self-lgtm in that sense.

approved based on #40363

@deads2k deads2k added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 27, 2017
@deads2k deads2k self-assigned this Jan 27, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 27, 2017
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 27, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @brendandburns
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-reviewable
Copy link

k8s-reviewable commented Jan 27, 2017 •
edited by apelisse
Loading

This change is Reviewable

@deads2k deads2k added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 27, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2017
@deads2k deads2k force-pushed the generic-32-movehttpstream branch from 0249ba2 to 7897ea8 Compare January 27, 2017 20:10
@deads2k deads2k added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 27, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2017
@sttts
Copy link
Contributor

sttts commented Jan 29, 2017

@k8s-bot unit test this

@sttts sttts mentioned this pull request Jan 29, 2017
Merged
@sttts
Copy link
Contributor

sttts commented Jan 29, 2017

Go CI Go!

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 4bba610 into kubernetes:master Jan 29, 2017
@deads2k deads2k deleted the generic-32-movehttpstream branch February 1, 2017 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @k8s-github-robot @k8s-reviewable @sttts @k8s-ci-robot