Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable test-cmd.sh tests #40428

Merged
merged 4 commits into from
Jan 25, 2017
Merged

Re-enable test-cmd.sh tests #40428

merged 4 commits into from
Jan 25, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 25, 2017 •
edited
Loading

Wrapping runTests in a subshell was masking return code failures
Moved init to top-level to properly install stack traces on exit

Fixes #39168

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@liggitt liggitt mentioned this pull request Jan 25, 2017
Closed
@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 25, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @zmerlynn
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Jan 25, 2017

cc @nikhiljindal @fabianofranz

@k8s-github-robot k8s-github-robot added kind/old-docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2017
eparis
eparis reviewed Jan 25, 2017
View reviewed changes
hack/make-rules/test-cmd-util.sh
@@ -2411,7 +2412,7 @@ run_multi_resources_tests() {
runTests() {
if [ -z "${SUPPORTED_RESOURCES}" ]; then
echo "Need to set SUPPORTED_RESOURCES env var. It is a comma separated list of resources that are supported and hence should be tested. Set it to (*) to test all resources"
return
exit 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPPORTED_RESOURCES is not a comma separated list, it is a bash array.

We'll never hit this echo if it was unset, since we'd die on the set -e. I think it should be be if [[ -z "${SUPPORTED_RESOURCES:-}" ]] for the (wrong) comment to ever pop...

hack/make-rules/test-cmd.sh
# to catch bugs due to which no tests run.
kube::test::if_has_string "${output_message}" "Testing kubectl(v1:pods)"
kube::test::if_has_string "${output_message}" "Testing kubectl(v1:services)"
runTests "SUPPORTED_RESOURCES=${SUPPORTED_RESOURCES[@]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to figure out what this does. I think this is passing a string as $1 to runTests() which is in turn never used for anything. runTests() does not appear to take any arguments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, will remove the arg-passing bit

hack/testdata/kubernetes-service.yaml
@@ -4,7 +4,6 @@ metadata:
name: kubernetes
namespace: default
spec:
clusterIP: 10.0.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this need killed? do we not need a predictable clusterIP ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was getting an "already allocated IP error" trying to create it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed a different way (try to create, tolerate already existing, then verify existence)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this is the IP it $needs to be, no? do we hit that before we hit 'resource exists' ?

@liggitt liggitt mentioned this pull request Jan 25, 2017
Closed
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed kind/old-docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 25, 2017
@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed release-note-label-needed labels Jan 25, 2017
@deads2k deads2k added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 25, 2017
@deads2k deads2k added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/P0 labels Jan 25, 2017
@deads2k
Copy link
Contributor

deads2k commented Jan 25, 2017

lgtm.

@eparis
Copy link
Contributor

eparis commented Jan 25, 2017

@deads2k please do not manually set approved labels. I know it is a PITA, but we've got to start using them. (agreed this LGTM)

@deads2k
Copy link
Contributor

deads2k commented Jan 25, 2017

@deads2k please do not manually set approved labels. I know it is a PITA, but we've got to start using them. (agreed this LGTM)

@eparis Sorry, I'll add more detail next time. I don't have sufficient power in OWNERS to approve this. It's fixing a p0 bug which allows more broken code into master. I judged it to be an appropriate use of power.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 40428, 40176)

@k8s-github-robot k8s-github-robot merged commit b4beb02 into kubernetes:master Jan 25, 2017
@liggitt liggitt deleted the test-cmd-tests branch January 25, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eparis eparis eparis left review comments

Assignees

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @k8s-reviewable @k8s-github-robot @deads2k @eparis @k8s-ci-robot