WIP: kube-proxy: remove OS conditionals. #40414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/XL
|
[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files: We suggest the following people: |
pires
changed the title
thockin
reviewed
Jan 27, 2017
| return fmt.Errorf("Proxying is not supported in this build") | ||
| } | ||
|
|
||
| func getConntrackMax(config *options.ProxyServerConfig) (int, error) { |
There was a problem hiding this comment.
why is this part of the "interface" only used in Linux.
| } | ||
|
|
||
| // Tune conntrack, if requested | ||
| func (s *ProxyServer) tuneConnTracker() error { |
There was a problem hiding this comment.
why isn't this just embedded in the _linux code?
There was a problem hiding this comment.
We're working on having connection tracking on Windows. Even though, I have reviewed partially addressed your concerns in a new commit.
k8s-github-robot
added
the
needs-rebase
pires
force-pushed
the
refactor_kube_proxy
branch
from
80b03ab to
79014b4
Compare
|
@jbhurat I have rebased the PR so make sure you have updated your working copy. |
k8s-github-robot
removed
the
needs-rebase
pires
force-pushed
the
refactor_kube_proxy
branch
2 times, most recently
from
a12c4cc to
79651da
Compare
pires
force-pushed
the
refactor_kube_proxy
branch
from
79651da to
ce1a774
Compare
k8s-github-robot
added
the
needs-rebase
|
@pires PR needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: in 1.5 we added Windows support to kube-proxy. This is part of an ongoing effort to improve what has been done. In this PR, we focused on removing OS checks based on previous feedback.
Which issue this PR fixes: fixes #36277
Special notes for your reviewer: @thockin a second step we'd like to discuss is how can we remove the need for the Windows code to not know about
iptables.Interfacetype. A third step could be to extract proxy modes as plug-ins, so that we can provide different implementations for Windows as well.Release note: