Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert kube-apiserver to hyperkube #3982

Merged
merged 1 commit into from
Jan 30, 2015
Merged

Convert kube-apiserver to hyperkube #3982

merged 1 commit into from
Jan 30, 2015
+411 −260

Conversation

jbeda
Copy link
Contributor

@jbeda jbeda commented Jan 30, 2015

Part of #108.

Also:

@jbeda
Copy link
Contributor Author

jbeda commented Jan 30, 2015

I'm running e2e tests now. This is a pretty simple refactor though (in theory).

@jbeda jbeda force-pushed the hyperkube-servers branch from cc9706d to 7aa0500 Compare January 30, 2015 17:50
@bgrant0607 bgrant0607 self-assigned this Jan 30, 2015
@bgrant0607
Copy link
Member

pkg/apiserver/server/server.go should be under pkg/master.

apiserver is general api infrastructure, used by openshift, and will be used by kubelet, also.

master is the kubernetes api server.

I didn't diff cmd/kube-apiserver/apiserver.go and pkg/apiserver/server/server.go. I assume you did. :-)

Probably should give a heads up to @smarterclayton.

@bgrant0607
Copy link
Member

FWIW, the Openshift instantiation of the master is here:
https://github.com/openshift/origin/blob/69b94514166d9b3cf2a212f6ebd65ff8d7066d2c/pkg/cmd/server/start.go#L459

@jbeda jbeda force-pushed the hyperkube-servers branch from 7aa0500 to 84d590b Compare January 30, 2015 20:36
@jbeda
Copy link
Contributor Author

jbeda commented Jan 30, 2015

@bgrant0607 -- PTAL -- moved it to pkg/master/server. I'm also watching all changes to cmd/apiserver to make sure I don't miss any merges.

@smarterclayton
Copy link
Contributor

Hyperkube, excellent name. Looking

@jbeda
Convert kube-apiserver to hyperkube.
6bdede6 
Part of kubernetes#108.

Also:
* Added hyperkube cmd (not built by default yet).
* Added version support to hyperkube
* Remove health_check_minions flag from apiserver as it is no longer used with kubernetes#3733
@jbeda jbeda force-pushed the hyperkube-servers branch from 84d590b to 6bdede6 Compare January 30, 2015 21:06
@bgrant0607
Copy link
Member

Works for me, if it's ok with @smarterclayton. I figure we can fix/tweak it as necessary after the initial refactor goes in.

@smarterclayton
Copy link
Contributor

Looks good to me but don't consider it authoritative.

@bgrant0607
Copy link
Member

Ok. Will merge when tests complete.

bgrant0607 added a commit that referenced this pull request Jan 30, 2015
@bgrant0607
Merge pull request #3982 from jbeda/hyperkube-servers
881f2dc 
Convert kube-apiserver to hyperkube
@bgrant0607 bgrant0607 merged commit 881f2dc into kubernetes:master Jan 30, 2015
@roberthbailey roberthbailey mentioned this pull request Mar 21, 2015
Closed
3 tasks
@jbeda jbeda deleted the hyperkube-servers branch October 13, 2016 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbeda @bgrant0607 @smarterclayton