Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #38730 #38899

Merged
merged 1 commit into from
Dec 17, 2016
Merged

Automated cherry pick of #38730 #38899

merged 1 commit into from
Dec 17, 2016

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Dec 16, 2016

Cherry pick of #38730 on release-1.5.

#38730: Automatically download missing kube binaries in

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2016
@ixdy
Copy link
Member Author

ixdy commented Dec 16, 2016

x-ref #38725
cc @arun-gupta @christian-posta

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Dec 16, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@ixdy ixdy added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 16, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit c20197f. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 16, 2016
@saad-ali saad-ali added this to the v1.5 milestone Dec 16, 2016
@saad-ali saad-ali removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Dec 16, 2016
@saad-ali
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2016
@saad-ali
Copy link
Member

@k8s-bot cvm gke e2e test this

@jbeda
Copy link
Contributor

jbeda commented Dec 16, 2016

/lgtm

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit c20197f. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit dccb2e8 into kubernetes:release-1.5 Dec 17, 2016
@ixdy ixdy deleted the automated-cherry-pick-of-#38730-upstream-release-1.5 branch May 15, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbeda jbeda

@saad-ali saad-ali

Labels
area/build-release cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
7 participants
@ixdy @k8s-reviewable @k8s-github-robot @k8s-cherrypick-bot @k8s-ci-robot @saad-ali @jbeda