Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPA e2e tests: fixed waiting for service creation. #38463

Merged
merged 1 commit into from
Dec 9, 2016
Merged

HPA e2e tests: fixed waiting for service creation. #38463

merged 1 commit into from
Dec 9, 2016

Conversation

jszczepkowski
Copy link
Contributor

HPA e2e tests: fixed waiting for service creation. Fixes #32512.

@k8s-reviewable
Copy link

This change is Reviewable

@jszczepkowski jszczepkowski requested a review from piosz December 9, 2016 11:20
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2016
@jszczepkowski jszczepkowski added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 9, 2016
@jszczepkowski jszczepkowski added this to the v1.5 milestone Dec 9, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 9, 2016
@jszczepkowski
Copy link
Contributor Author

@k8s-bot verify test this

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 65b2cf0. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

piosz
piosz reviewed Dec 9, 2016
View reviewed changes
test/e2e/autoscaling_utils.go
// Make sure endpoints are propagated.
// TODO(piosz): replace sleep with endpoints watch.
time.Sleep(10 * time.Second)
// Wait for endpoints to propagate for the controller service.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check whether there is no similar function in test utils?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was! Fixed.

@jszczepkowski
HPA e2e tests: fixed waiting for service creation.
2b070e1 
HPA e2e tests: fixed waiting for service creation. Fixes kubernetes#32512.
@jszczepkowski
Copy link
Contributor Author

@piosz PTAL

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2016
@dims
Copy link
Member

dims commented Dec 9, 2016

@jszczepkowski Move the milestone please if appropriate?

@jszczepkowski jszczepkowski removed this from the v1.5 milestone Dec 9, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@jszczepkowski jszczepkowski mentioned this pull request Dec 9, 2016
Closed
@piosz
Copy link
Member

piosz commented Dec 9, 2016

LGTM

@piosz piosz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 37860, 38429, 38451, 36050, 38463)

@k8s-github-robot k8s-github-robot merged commit 59cfdfb into kubernetes:master Dec 9, 2016
@jszczepkowski jszczepkowski added this to the v1.5 milestone Dec 12, 2016
This was referenced Dec 12, 2016
Closed
Closed
Merged
@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 14, 2016
k8s-github-robot pushed a commit that referenced this pull request Dec 14, 2016
Merge pull request #38682 from jszczepkowski/automated-cherry-pick-of…
f1a1a2c 
…-#38463-upstream-release-1.5

Automatic merge from submit-queue

Cherry-pick of #38463: fix in HPA e2e tests

HPA e2e tests: fixed waiting for service creation. Fixes #38549.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piosz piosz piosz left review comments

Assignees

@piosz piosz

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
8 participants
@jszczepkowski @k8s-reviewable @k8s-ci-robot @dims @k8s-cherrypick-bot @piosz @k8s-github-robot @saad-ali