-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support skipping the validity check of keystone server's certificate #35280
Conversation
Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Regular contributors should join the org to skip this step. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
cc @kubernetes/sig-auth |
I'm opposed to this change. Authenticators should always verify who they are speaking to. Plumbing through an option to allow a custom CA for verifying the keystone server's serving cert would be fine with me, but I think that bypassing it entirely is unreasonable. Any flag like this that is added as a "never use this in production" will almost certainly be used in production and the barrier to adding your cert as a CA is relatively minor. |
I agree. |
b9ed704
to
267ae1a
Compare
267ae1a
to
2323a51
Compare
if you'd like to rework this to pass in a custom CA bundle to use to verify the keystone server, I think that would be fine, but I don't see adding this option. |
closing in favor of #35488 |
What this PR does / why we need it:
Sometimes the keystone server's certificate is self-signed, mainly used for internal development, testing and etc.
Of course, a trusted root certificate for keystone server can be added manually.
Otherwise, below error will occur.
However, this patch provides an alternative and easy way to support such scenario.
Which issue this PR fixes : fixes #22695, #24984
Special notes for your reviewer:
Release note:
This change is