Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #34955 #35046

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Automated cherry pick of #34955 #35046

merged 1 commit into from
Oct 18, 2016

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Oct 18, 2016 •
edited by k8s-oncall
Loading

Cherry pick of #34955 on release-1.4.
#34955: HPA: fixed wrong count for target replicas calculations.

This change is Reviewable

@jszczepkowski @jessfraz
HPA: fixed wrong count for target replicas calculations.
d5ad431 
HPA: fixed wrong count for target replicas calculations (kubernetes#34821).
@jessfraz jessfraz added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Oct 18, 2016
@jessfraz jessfraz added this to the v1.4 milestone Oct 18, 2016
@jessfraz jessfraz self-assigned this Oct 18, 2016
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 18, 2016
@jessfraz jessfraz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit d5ad431. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit d5ad431. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit c47ba9e into kubernetes:release-1.4 Oct 18, 2016
@jessfraz jessfraz deleted the automated-cherry-pick-of-#34955-origin-release-1.4 branch October 18, 2016 18:54
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#35046 from jessfraz/automated-cherry-pi…
8d1790e 
…ck-of-#34955-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#34955

Cherry pick of kubernetes#34955 on release-1.4.

kubernetes#34955: HPA: fixed wrong count for target replicas calculations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jessfraz jessfraz

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@jessfraz @k8s-github-robot @k8s-ci-robot @k8s-cherrypick-bot @googlebot @jszczepkowski