Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line.

Regular contributors should join the org to skip this step.

This may fail a few times as it's not easy for me to test it in my old hardware. But if you can authorize it to test, it would be great :)

Also, configmap e2e are way more extensive than secrets. It's easy to add similar tests on secrets while doing this functions, so let me know if it's ok to do it

Nice improvement @rata! Will someone from @kubernetes/sig-storage give assign this to themselves and give it a quick review?

@fejta thanks! Do you think it's "ok to test" so we can actually see it works fine?

@k8s-bot ok to test

LGTM

@saad-ali thanks! :)

No problem! Thanks for the cleanup

Jenkins GCE Node e2e failed for commit a7b405930cc488d4a0f0d77b27222940eaa9885a. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Jenkins GCI GCE e2e failed for commit a7b405930cc488d4a0f0d77b27222940eaa9885a. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Jenkins GCE e2e failed for commit a7b405930cc488d4a0f0d77b27222940eaa9885a. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Jenkins Kubemark GCE e2e failed for commit a7b405930cc488d4a0f0d77b27222940eaa9885a. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Jenkins GCI GKE smoke e2e failed for commit 84985b0440bf84b13d086c345073d6c301db301b. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Jenkins GKE smoke e2e failed for commit 0ff2f08. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@saad-ali I've just rebased and pushed today, because I thought the last 3 faild were flaky. And it seems they are, as now only one fails.

Should I just retry until this passes? Or what should I do in this case? (looking at the error, it seems unrelated)

Should I just retry until this passes? Or what should I do in this case? (looking at the error, it seems unrelated)

Yes, but you don't have to do a rebase/push to trigger retest.

@k8s-bot gke e2e test this, Issue: #33175

@saad-ali thanks! I do rebase/amend and push because I think I don't have permissions to send that command to the bot :-)

Right, sorry about that

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

Automatic merge from submit-queue