Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #32413 #32418

Closed
wants to merge 1 commit into from
Closed

Automated cherry pick of #32413 #32418

wants to merge 1 commit into from

Conversation

freehan
Copy link
Contributor

@freehan freehan commented Sep 9, 2016 •
edited
Loading

Cherry pick of #32413 on release-1.4.

cc: @thockin

This change is Reviewable

@freehan freehan added this to the v1.4 milestone Sep 9, 2016
@freehan freehan added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 9, 2016
@pwittrock
Copy link
Member

Should we do this as part of a batch cherry pick?

@k8s-github-robot k8s-github-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2016
@fabioy fabioy added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 9, 2016
@k8s-bot
Copy link

k8s-bot commented Sep 9, 2016

GCE e2e build/test passed for commit c4bde8d.

@bprashanth
Copy link
Contributor

I thought that was the plan, there're a couple more prs that need 1.4 cherrypicking if we're not batching (#31990, #31828)

@pwittrock pwittrock added cherrypick-candidate and removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Sep 9, 2016
@pwittrock
Copy link
Member

@bprashanth SGTM. We don't need this then right, and just apply the label to #32413 .

@k8s-github-robot k8s-github-robot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 9, 2016
@foxish
Copy link
Contributor

foxish commented Sep 10, 2016

Closing this as we're batching.

@foxish foxish closed this Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pwittrock pwittrock

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
8 participants
@freehan @pwittrock @k8s-bot @bprashanth @foxish @googlebot @fabioy @k8s-github-robot