Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle condition where minion cbr0 interface is up, but not yet readdressed, when vSphere script sets up cluster networking #31672

Closed
wants to merge 2 commits into from
Closed

Handle condition where minion cbr0 interface is up, but not yet readdressed, when vSphere script sets up cluster networking #31672

wants to merge 2 commits into from

Conversation

kb1ca
Copy link

@kb1ca kb1ca commented Aug 30, 2016 •
edited by k8s-oncall
Loading

What this PR does / why we need it: Resolves bug reported in #31310

Which issue this PR fixes (optional, in fixes #<issue number>(, #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #31310

Special notes for your reviewer:

Release note: NONE

This change is Reviewable

kb1ca added 2 commits August 29, 2016 18:45
@kb1ca
Add files via upload
5570683 
Add additional logic to vSphere cluster quickstart script to handle situation where cbr0 interface is brought up but not immediately configured with the final subnet. Due to order of operations this would always occur with the highest numbered (ie. last to deploy) minion in the cluster.

Previously the script would blindly push configuration for the default 172.18.0.0/16 subnet into the cluster, only for the cbr0 interface to eventually become reconfigured with the correct final subnet, breaking networking with containers deployed to that node.

Also made the status messaging regarding the inter-node routing setup more verbose and added a missing newline.
@kb1ca
Add files via upload
e55162e 
Remove errant 'All rights reserved'.
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Aug 30, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

8 similar comments
@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@imkin
Copy link

imkin commented Oct 19, 2016

@zmerlynn I can verify this fix for you. Do you need any different help for this?

@zmerlynn
Copy link
Member

I just haven't seen it in a while, sorry for the delay.

@k8s-bot test this

@zmerlynn
Copy link
Member

The CNCF CLA issue has to be resolved. You should squash the commits anyways, so if you fix the CLA issues and squash, it should tickle the bot.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit e55162e. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit e55162e. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@kerneltime
Copy link

@zmerlynn I am including a fix for the issue here with updates in a PR that is in the works. Will update this PR when it is posted.
@kb1ca Thank you for root causing and posting this PR.

@kerneltime kerneltime mentioned this pull request Oct 20, 2016
Merged
@kerneltime
Copy link

@zmerlynn posted #35232

k8s-github-robot pushed a commit that referenced this pull request Oct 21, 2016
Merge pull request #35232 from vmware/fix-dashboard.kerneltime
0dbd954 
Automatic merge from submit-queue

vSphere kube-up: Wait for cbr0 configuration to complete before setting up routes.

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**:
Fixes routing setup when deploying via kube-up.sh on vSphere.
Remove optimizations for salt status check till flakyness of install with optimization
is addressed.

**Which issue this PR fixes**  
fixes #34248, #31310 

**Special notes for your reviewer**:
Ref PR with a similar fix #31672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Following Getting Started Guide for vSphere results in incomplete Pod network routes on minion nodes
8 participants
@kb1ca @k8s-bot @imkin @zmerlynn @k8s-ci-robot @kerneltime @googlebot @k8s-github-robot