Add a script suitable for wget https://get.k8s.io | sh installation #3106
Conversation
| set -o nounset | ||
| set -o pipefail | ||
|
|
||
| release=v0.7.0 |
There was a problem hiding this comment.
We have to change this every release? That seems unfortunate.
There was a problem hiding this comment.
Yeah, there is no "latest.tar.gz" at least not yet.
brendandburns
force-pushed
the
simple
branch
from
d235ed4 to
f64d8f7
Compare
|
comments addressed. ptal |
| rm ${file} | ||
|
|
||
| echo "Installing kubernetes..." | ||
| cd kubernetes |
There was a problem hiding this comment.
nit: It might be better to do this in a subshell so that you don't have to cd .. later in the script.
roberthbailey
added
the
lgtm
brendandburns
force-pushed
the
simple
branch
from
f64d8f7 to
3414121
Compare
|
I like the simplicity. But, why GCE + 0.7.1 as the default, and not GKE as the default? |
|
Switched to v0.7.1. I realized the GKE provider isn't there for the v0.7.1 release (it will be part of v0.8.0) I'll update the script when that is released. ptal. |
brendandburns
force-pushed
the
simple
branch
from
f82f9fe to
3b8e98c
Compare
|
Sgtm
|
|
Should this be merged, or are we waiting for v0.8 to land? |
|
Fine with me to merge. It works with 0.7.x, will update to 0.7.2 when it Brendan
|
|
My only concern with this is that we'll have to modify it manually when we push releases. The link |
|
https://github.com/GoogleCloudPlatform/kubernetes/releases/latest/kubernetes.tar.gz doesn't work though, so we'd need some shell hackery to support that, I'd rather do that in a different PR. Updated to 0.7.2 |
|
In #3238 I proposed a way for a new CI bucket to have a latest "link" that's just a text file. It would be trivial just to plumb this through the official push process as well. |
| elif [[ "${uname}" == "Linux" ]]; then | ||
| platform="linux" | ||
| else | ||
| echo "Unknown, unsupported platform: (${uname}). Bailing out." |
There was a problem hiding this comment.
Perhaps some more info about what platforms are supported?
| echo "Installing kubernetes..." | ||
| ( | ||
| cd kubernetes | ||
| ./cluster/kube-up.sh |
There was a problem hiding this comment.
If this fails (say they don't have gcutil installed) we should give them the command to run to try again. They shouldn't have to re-download everything.
|
@lavalamp @brendandburns what is the status of this PR. |
|
I addressed Joe's comments. Would like to merge if everyone is happy. Thanks! |
| ) | ||
| } | ||
|
|
||
| if [[ "x${KUBERNETES_SKIP_DOWNLOAD}" != "x" ]]; then |
There was a problem hiding this comment.
Document in comment block up top.
There was a problem hiding this comment.
nounset will trip you up here. Also, you don't need the "x" trick.
if [[ -n "${KUBERNETES_SKIP_DOWNLOAD-}" ]]; then
...
fi
|
I'm cool with you merging after you address comments. We'll have to deal with the hard coded version sooner rather than later. |
|
addressed comments and re-tested. will merge on green. |
|
LGTM |
Add a script suitable for wget https://get.k8s.io | sh installation
No description provided.