I reviewed the provisioner and it looks pretty solid at this point.

@jsafrane Thanks for the review. I've just modified it based on your comments. I think there's no point to hurry, as it won't be merged into 1.4 anyhow?

GCE e2e build/test passed for commit fbdbb1b.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

it won't be merged into 1.4 anyhow

No, this is for 1.5. I went through current versions, just a few documentation nits found. Please rebase and finish the deleter!

Reviewed 3 of 22 files at r1, 3 of 20 files at r2, 19 of 19 files at r3, 9 of 9 files at r4.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

pkg/api/types.go, line 746 [r4] (raw file):

// Flocker volumes do not support ownership management or SELinux relabeling.
type FlockerVolumeSource struct {
  // One and only one of the following should be specified.

IMO, this line should be in FlockerVolumeSource docs, i.e. two lines up ("only one of DatasetName and DatasetUUID should be set"). Otherwise it's godoc of DatasetName, which is quite confusing.

pkg/api/v1/types.go, line 651 [r4] (raw file):

// Flocker volumes do not support ownership management or SELinux relabeling.
type FlockerVolumeSource struct {
  // One and only one of the following should be specified.

dtto, this is godoc of DatasetName, which does not make sense.

Comments from Reviewable

Review status: 0 of 38 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

pkg/api/types.go, line 746 [r4] (raw file):

pkg/api/v1/types.go, line 651 [r4] (raw file):

Comments from Reviewable

@k8s-bot gci gce e2e test this
@k8s-bot gke e2e test this

Jenkins GCI GCE e2e failed for commit 77bf500. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-bot gci gce e2e test this
@k8s-bot gke e2e test this

@jsafrane if you have the chance, could you do another review please? From my point of view it's ready to merge.,

Do you think an exampe is necessary (like the ones in https://github.com/kubernetes/kubernetes/tree/master/examples/experimental/persistent-volume-provisioning)?

Reviewed 1 of 24 files at r1, 1 of 20 files at r2, 6 of 42 files at r5, 14 of 34 files at r8, 13 of 13 files at r9, 9 of 9 files at r10.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

almost LGTM, only all log messages should start with lowercase. Simple grep for glog will reveal them all. I should have noticed it earlier.

@jsafrane Ok I have downcased all the log messages

Reviewed 1 of 24 files at r1, 1 of 20 files at r2, 6 of 42 files at r5, 5 of 13 files at r9, 1 of 23 files at r11, 13 of 13 files at r12, 9 of 9 files at r13.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

LGTM. Thanks a lot for the PR!

@jsafrane I think the only thing missing now is the reviewable "discussions"

Thanks for reviewing!

reviewable discussions are optional, important is that "Submit Queue" is green - it's in the queue and it will be merged eventually.

@jsafrane 👍 thanks for clarifying, not too familiar with reviewable yet

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

Jenkins GKE smoke e2e failed for commit cd08978. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Automatic merge from submit-queue

I get an error from kubelet when mounting flocker volumes using hyperkube:1.5.1
When using hyperkube:1.4.8 everything workes fine.
I do not use dynamic volume provisioning (I.e.I created flocker volume first using flockerctl)

Kube Setup:
Ubuntu trusty nodes
I am using my own extension to docker-multinode that integrates with flocker: https://github.com/eddytruyen/kube-deploy/tree/master/docker-multinode

Flocker Setup: 1.15
Datasetprovider: Cinder (openstack)

Error log when deploying mysql: https://github.com/kubernetes/kubernetes/tree/master/examples/mysql-wordpress-pd. (I changed the volume YAML file such that a localhost volume is changed into a flocker dataset):

  11m           1m              13      {kubelet k8-worker-1}                 
Warning          FailedMount     MountVolume.SetUp failed for volume "kubernetes.io/flocker/38b02b01-dfb5-11e6-83a8-fa163ef52647-local-pv-1" (spec.Name: "local-pv-1") pod "38b02b01-dfb5-11e6-83a8-fa163ef52647" (UID: "38b02b01-dfb5-11e6-83a8-fa163ef52647") with: mount failed: exit status 32
Mounting command: mount
Mounting arguments: /flocker/286d6e19-e715-49e8-9eab-489b325a7d9c /var/lib/kubelet pods/38b02b01-dfb5-11e6-83a8-fa163ef52647/volumes/kubernetes.io~flocker/local-pv-1  [bind]
Output: mount: special device /flocker/286d6e19-e715-49e8-9eab-489b325a7d9c does not exist

@WitoDelnat