Make list pods constant time #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Clock allows for injecting fake or real clocks into | ||
| // the cache. | ||
| type Clock interface { |
There was a problem hiding this comment.
This is duplicated in N places. we should really pull this out into a util. (and if you don't do that, this should probably be private.)
| lastUpdate time.Time | ||
| } | ||
|
|
||
| type ipCache struct { |
There was a problem hiding this comment.
We should really extract this out into a generic cache.
|
generally LGTM, small stuff to fix. thx! |
* move ip cache out of registry/pod * combine, rationalize, and move pod status logic * Fix unit and integration tests
|
Review comments addressed, going to try & run e2e now. |
|
|
||
| // Every return path from this function stores a status in the cache, even | ||
| // error cases. | ||
| defer func() { |
There was a problem hiding this comment.
Please don't defer an anonymous function, I think it really hurts readability.
And in general this function is structured really weirdly.
How about extracting out a "constructNewStatus" function, and then only setting the status once at the end.
|
Basically LGTM, modulo fixing that one last function. |
lavalamp
force-pushed
the
optimize
branch
2 times, most recently
from
8335733 to
8b588ac
Compare
add test for node existence cache behavior
|
LGTM, will merge on green... |
brendandburns
added a commit
that referenced
this pull request
Dec 22, 2014
Make list pods constant time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all status-computing logic to the pod cache, and also starts caching more things (like whether a node exists). Will make it easier in the future to move status computation into a separate process or all the way down to kubelet.
Fixes #2951
Fixes #2975
Improves #2922
I'm having troubles running e2e. Will figure that out tomorrow and also squash.