@nikhiljindal I guess you are already aware of this since you are one of the assigned reviewers, but just drawing your attention - PR #30615. Also, I do not want to block this PR, but I just want to give you a heads-up. I am going to rip out all the shell scripts that the initialization code implements to avoid having multiple competing implementations in our repo. My plan is to leave the shell scripts as is in 1.4 to whet the new code a bit and remove them in 1.5 time frame.

@nikhiljindal based on our offline discussion and to unblock you from accessing swagger spec, I have reviewed this PR. A couple of minor nits, then please feel free to add the LGTM label yourself.

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions.

cluster/common.sh, line 854 [r1] (raw file):

  }
}

Unnecessary blank line here.

federation/cluster/common.sh, line 248 [r1] (raw file):

  local kube_temp="${KUBE_TEMP}/federation"
  mkdir "${kube_temp}"

you need mkdir -p for safety (or handle error).

Comments from Reviewable

Thanks @madhusudancs
Yes sorry for missing #30615.
It will be cool to convert the shell script code to Go! Didnt realize that we were going to do that in 1.4!

I have updated the code as per comments.
Also updated the code to generate a valid random password (reused existing function that generates kube password) rather than using "admin".
Thanks!

Reviewed 2 of 4 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

LGTM!

Updated hack/verify-flags/exceptions.txt to fix hack/verify-flags-underscore.py

what makes this a p1?

@k8s-bot unit test this issue: #30754

GCE e2e build/test passed for commit 56a2458.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit 56a2458.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue