Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make verify-godeps check the results #29920

Merged
merged 1 commit into from
Aug 4, 2016
Merged

Make verify-godeps check the results #29920

merged 1 commit into from
Aug 4, 2016

Conversation

thockin
Copy link
Member

@thockin thockin commented Aug 2, 2016

Verify the results of godep restore/save. When forced to run this finds a handful of real deltas that need to be resolved.

Fixes #29402

@rmmh because you wrote #29571 which is the major culprit

@thockin
Copy link
Member Author

thockin commented Aug 2, 2016

@lavalamp FYI

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Aug 2, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 2, 2016

GCE e2e build/test passed for commit b9d68ab.

@rmmh rmmh mentioned this pull request Aug 2, 2016
Merged
@thockin thockin added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Aug 2, 2016
k8s-github-robot pushed a commit that referenced this pull request Aug 3, 2016
Merge pull request #29940 from rmmh/fix-godeps
74c6dbc 
Automatic merge from submit-queue

Fix bad Godeps.

These changes make the updated verify-godeps.sh in #29920 pass.

Fixes #29402.
@thockin
Copy link
Member Author

thockin commented Aug 3, 2016

OK. This should be clear for review/merge now

@thockin
Copy link
Member Author

thockin commented Aug 3, 2016

@rmmh for review

@rmmh rmmh added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 4, 2016

GCE e2e build/test passed for commit b9d68ab.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 0e55753 into kubernetes:master Aug 4, 2016
@thockin thockin deleted the verify-godeps-results branch November 2, 2016 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rmmh rmmh

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

verify godeps doesn't
5 participants
@thockin @k8s-bot @k8s-github-robot @rmmh @googlebot