-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #29139 #29157
Automated cherry pick of #29139 #29157
Conversation
we need to add the dateformat option so that the logrotate can create unique logfiles for each rotation. Without this, we logrotation is skipped with message like (generated in verbose mode of logrotate): rotating log /var/log/rotate-test.log, log->rotateCount is 5 dateext suffix '-20160718' glob pattern '-[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]' destination /var/log/rotate-test2.log-20160718.gz already exists, skipping rotation Tested as follows: # config in '/etc/logrotate.d/rotate-test': /var/log/rotate-test.log { rotate 5 copytruncate missingok notifempty compress maxsize 100M daily dateext dateformat -%Y%m%d-%s create 0644 root root } # create 150Mb of /var/log/rotate-test.log $ dd if=/dev/zero of=/var/log/rotate-test.log bs=1048576 count=150 conv=notrunc oflag=append # run logrotate $ /usr/sbin/logrotate -v /etc/logrotate.conf ... rotating pattern: /var/log/rotate-test.log after 1 days (5 rotations) empty log files are not rotated, log files >= 104857600 are rotated earlier, old logs are removed considering log /var/log/rotate-test.log log needs rotating rotating log /var/log/rotate-test.log, log->rotateCount is 5 Converted ' -%Y%m%d-%s' -> '-%Y%m%d-%s' dateext suffix '-20160718-1468875268' glob pattern '-[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]' copying /var/log/rotate-test.log to /var/log/rotate-test.log-20160718-1468875268 truncating /var/log/rotate-test.log compressing log with: /bin/gzip Repeating 'dd' and 'logrotate' commands now generate logfiles correctly.
LGTM. Thanks! |
@bprashanth Could you rebase this? Thanks. |
@bprashanth NVM about the rebase -- misread the checks. Thanks. |
@k8s-bot e2e test this, issue #IGNORE |
@zmerlynn |
GCE e2e build/test passed for commit 4a1d8f5. |
Adding retest-not-required after SQ reboot. |
Automatic merge from submit-queue |
…pick-of-#29139-upstream-release-1.3 Automatic merge from submit-queue Automated cherry pick of kubernetes#29139 Cherry pick of kubernetes#29139 on release-1.3.
Cherry pick of #29139 on release-1.3.