Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PodToleratesNodeTaints to GeneralPredicates #29116

Closed
wants to merge 1 commit into from
Closed

Move PodToleratesNodeTaints to GeneralPredicates #29116

wants to merge 1 commit into from

Conversation

lukaszo
Copy link
Contributor

@lukaszo lukaszo commented Jul 18, 2016 •
edited
Loading

Related issue: #25320 #29276

I've run e2e tests for SchedulerPredicates [Serial] and it seems to be working.

This change is Reviewable

@lukaszo
Copy link
Contributor Author

lukaszo commented Jul 18, 2016

When #28803 is merged DaemonSets will also be able to use Taints/Tolerations

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jul 18, 2016
@davidopp
Copy link
Member

I'm not sure we want to move this to GeneralPredicates yet. Also I am very backed up right now, so it will be a few days until I get to this. (But please do not reassign it to someone else.)

@lukaszo
Copy link
Contributor Author

lukaszo commented Jul 19, 2016

If it's not yet ready to be moved to GeneralPredicates what else is required to be done? I can work on it.

My goal is to be able to use Taints/Toleration in DaemonSets. My ultimate goal is to fix problems with NodeSpec.unschedulable see #29178 for more details.

@lukaszo lukaszo mentioned this pull request Jul 21, 2016
Merged
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. retest-not-required-docs-only and removed retest-not-required-docs-only labels Jul 28, 2016
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 4, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 10, 2016

GCE e2e build/test passed for commit 55d32b2.

@apelisse apelisse removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Aug 11, 2016
@k8s-github-robot
Copy link

This PR hasn't been active in 30 days. It will be closed in 59 days (Oct 17, 2016).

cc @davidopp @lukaszo

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

@k8s-github-robot
Copy link

@lukaszo PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2016
@lukaszo
Copy link
Contributor Author

lukaszo commented Aug 22, 2016

After merging #31020 my PR is not needed anymore. Closing

@lukaszo lukaszo closed this Aug 22, 2016
@ivan4th ivan4th mentioned this pull request Sep 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lukaszo @davidopp @k8s-bot @k8s-github-robot @apelisse @googlebot