Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with closing channels in job controller tests #28948

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Fix issue with closing channels in job controller tests #28948

merged 1 commit into from
Jul 14, 2016

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jul 14, 2016

Fixes #28941.

@wojtek-t ptal

@wojtek-t
Copy link
Member

lgtm

@wojtek-t wojtek-t added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jul 14, 2016
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 14, 2016
@soltysh soltysh added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 14, 2016
@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 14, 2016

GCE e2e build/test passed for commit fd76f71.

@dims
Copy link
Member

dims commented Jul 14, 2016

Looks good to me 👍

@wojtek-t
Copy link
Member

Merging manually to fix problems for submit queue.

@wojtek-t wojtek-t merged commit 31d09f5 into kubernetes:master Jul 14, 2016
@soltysh soltysh deleted the issue28941 branch July 15, 2016 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bprashanth bprashanth

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@soltysh @wojtek-t @k8s-bot @dims @googlebot @bprashanth @k8s-github-robot