Use TLS 1.2 to access healthz API #28895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
dims
force-pushed
the
fix-issue-26169
branch
5 times, most recently
from
2da2ab1 to
0d34e6c
Compare
k8s-github-robot
added
size/M
| @@ -1211,7 +1211,13 @@ function wait-master() { | |||
| echo " up." | |||
| echo | |||
|
|
|||
| until $(curl --insecure --user ${KUBE_USER}:${KUBE_PASSWORD} --max-time 5 \ | |||
| if [[ $(curl -V | awk '{print $2}' | head -1) > 7.34.0 ]]; then | |||
| TLS_OPTS="--insecure --tlsv1.2" | |||
There was a problem hiding this comment.
It seems like none of these are useful because we are always using --insecure. What extra security does this provide?
There was a problem hiding this comment.
Mike,
--insecure tells libcurl to not verify the peer (https://curl.haxx.se/docs/sslcerts.html). If you see the man page, it has additional details
(SSL) This option explicitly allows curl to perform "insecure" SSL connections and transfers. All SSL connections are attempted to be made secure by using the CA certificate bundle installed by default. This makes all connections considered "insecure" fail unless -k, --insecure is used.
fyi. bug reporter has confirmed that adding this option makes the scenario work.
the bug reporter has confirmed that adding --tlsv1.2 works as well.
Thanks,
Dims
k8s-github-robot
added
do-not-merge
In the following PR, TLS was set to 1.2 as the minimum because TLS1.0 and TLS1.1 are vulnerable: kubernetes#26169 However the scripts that used curl were not updated to match the TLS version. Since --tlsv1.2 was introduced in curl 7.34.0, we should check the version before using the option. Fixes kubernetes#28888
|
GCE e2e build/test passed for commit 1eb2348. |
|
@mikedanese Does not look like there's much interest in this PR. Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following PR, TLS was set to 1.2 as the minimum
because TLS1.0 and TLS1.1 are vulnerable:
#26169
However the scripts that used curl were not updated to match
the TLS version.
Fixes #28888