Migrate to kuberetes-release-dev #28792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerlynn
added
the
release-note
k8s-github-robot
added
the
size/XS
|
@ixdy is OOO, @spxr, care to look? Or @david-mcmahon? |
| @@ -1228,7 +1228,7 @@ function kube::release::gcs::copy_release_artifacts() { | |||
|
|
|||
| gsutil ls -lhr "${gcs_destination}" || return 1 | |||
|
|
|||
| if [[ -n "${KUBE_GCS_RELEASE_BUCKET_MIRROR:-}" ]]; then | |||
| if [[ "${KUBE_GCS_RELEASE_BUCKET_MIRROR:-}" != "${KUBE_GCS_RELEASE_BUCKET}" ]]; then | |||
There was a problem hiding this comment.
If KUBE_GCS_RELEASE_BUCKET_MIRROR is empty but KUBE_GCS_RELEASE_BUCKET is not will this break?
There was a problem hiding this comment.
Yes. I knew I meant to leave the -n in as well. Jussec.
|
PTAL |
This turns off the kubernetes-release-dev mirror. kubernetes#28193 should have shifted all the references over, this should ensure that it's true.
|
This looks fine to me. |
zmerlynn
added
the
do-not-merge
|
cc @roberthbailey .. I'll release the do-not-merge when the GKE side has been finished. |
|
GCE e2e build/test passed for commit 3edbadc. |
|
LGTM |
zmerlynn
removed
the
do-not-merge
|
I'm self-labeling this after enough LGTM-y comments. :) |
zmerlynn
added
lgtm
|
Automatic merge from submit-queue |
zmerlynn
added
cherrypick-candidate
cherry-pick-approved
zmerlynn
added
the
cherry-pick-approved
|
Approving cherrypick based on prior discussions. Someone can rescind if they object. |
This was referenced Jul 12, 2016
zmerlynn
added a commit
that referenced
this pull request
Jul 12, 2016
…92-upstream-release-1.2 Automated cherry pick of #28792
roberthbailey
added
release-note-none
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ck-of-#28792-upstream-release-1.3 Automatic merge from submit-queue Automated cherry pick of kubernetes#28792 Cherry pick of kubernetes#28792 on release-1.3.
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ck-of-#28792-upstream-release-1.2 Automated cherry pick of kubernetes#28792
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…ck-of-#28792-upstream-release-1.2 Automated cherry pick of kubernetes#28792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns off the kubernetes-release-dev mirror. #28193 should have shifted all the references over, this should ensure that it's true.
Along the way: Modify it so that the equal bucket and mirror is a noop for things like kubernetes/test-infra#244.