Add support for libStorage as a Kubernetes volume plugin. #28599

vladimirvivien · 2016-07-07T14:00:09Z

This change is to implement the libStorage storage provisioner and orchestrator framework as a Kubernetes volume plugin. LibStorage is an open source project from EMC {code}. One of its primary goals is provide persistent volume access to containerized applications. The libStorage framework comes with a stable API and a robust set of storage primitives including:

Volume creation
Volume inspection
Mount and unmount
Attach and detach

LibStorage offers a simple model for creating drivers for storage provisioning and orchestration. Storage drivers use a small but versioned API to implement some or all storage primitives. The drivers are automatically managed by the libStorage infrastructure. LibStorage exists to provide uniform access to the sizable and diverse storage platforms found in enterprise deployments. A libStorage volume plugin would allow Kubernetes to support many of these platforms while decoupling their implementations from the Kubernetes codebase.

The goals of the libStorage Kubernetes volume plugin are:

Mitigate the efforts of implementing k8s volume services
Grow the list of enterprise storage platforms available to k8s
Provide a portable storage API to third-party storage implementers

The libStorage volume plugin is designed to be cloud and provider agnostic. The volume is able to handle both PVs and PVCs. To enable libStorage as a dynamic persistent volume provisioner, use the --enable-libstorage-provisioner flag when launching the kube-controller-manager. This will use libStorage to automatically provision volumes defined in a Persistent Volume Claim.

This change is

googlebot · 2016-07-07T14:00:14Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

eparis · 2016-07-07T16:49:50Z

ok to test

eparis · 2016-07-07T16:50:29Z

@kubernetes/sig-storage

pmorie · 2016-07-07T16:52:32Z

Suggestion: this would probably be easier to review if it was split into multiple commits like so:

API changes
Generated code
Volume plugin

eparis · 2016-07-07T16:58:17Z

godeps updates/changes in a single commit.

vladimirvivien · 2016-07-07T20:03:46Z

Working on breaking out auto-gen code from real code changes.

vladimirvivien · 2016-07-08T15:19:57Z

@pmorie I followed your suggestion and reset the feature branch and broke out the code into 3 separate commits to make it easy to review .

See 7f435b24bc3f4d722855b18a9c8339cf736eb417 - libStorage source changes
See 56790fa95fe89e6b906030a69bf25b4d46777384 - Godep dependencies
See 9005111dd2d81c35bbeae1f49ec3277161edb585 - Auto-generated sources

k8s-bot · 2016-07-11T17:32:20Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

vladimirvivien · 2016-07-11T23:10:04Z

I signed it!

googlebot · 2016-07-11T23:10:06Z

CLAs look good, thanks!

vladimirvivien · 2016-07-11T23:16:52Z

@kubernetes/sig-storage

rootfs · 2016-07-17T12:46:48Z

About enable-libstorage-provisioner option, please coordinate with #29006

thockin · 2016-07-18T05:15:09Z

Godeps/Godeps.json

@@ -18,6 +18,11 @@
 			"Rev": "'75cd24fc2f2c2a2088577d12123ddee5f54e0675'"
 		},
 		{
+			"ImportPath": "github.com/BurntSushi/toml",


For a start we CAN NOT use this dep - it is licensed under the WTFPL which is not allowed.

https://news.ycombinator.com/item?id=5733050#up_5733477

Thanks for reviewing, I have asked the developer associated with the code using this WTFPL licensed dep to investigate alternatives

k8s-github-robot · 2017-01-03T20:04:52Z

Adding label:do-not-merge because PR changes docs prohibited to auto merge
See http://kubernetes.io/editdocs/ for information about editing docs

This commit captures the code changes for implementating the Kubernetes libStorage volume plugin including: - LibStoragetVolumeSource API type - LibStorage Plugin Impl - LibStorage impl of Mounter, Unmounter, Provisioner, etc - LibStorage client code

This commit encapsulates all source and doc artifacts generated by the build scripts including - API documentations - Source code for API types - Other build artifacts - Etc

This commit includes all example documentation showing how to use the libStorage Kuberneties volume plugin.

k8s-ci-robot · 2017-01-04T15:37:36Z

Jenkins Bazel Build failed for commit 4d073df. Full PR test history.

The magic incantation to run this job again is @k8s-bot bazel test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vladimirvivien · 2017-01-04T21:00:09Z

@k8s-bot unit test this

k8s-ci-robot · 2017-01-04T21:26:28Z

Jenkins unit/integration failed for commit 4d073df. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-github-robot · 2017-01-09T21:25:49Z

@vladimirvivien PR needs rebase

k8s-github-robot · 2017-01-23T22:05:52Z

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

OWNERS

We suggest the following people:
cc @lavalamp
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

googlebot added the cla: no label Jul 7, 2016

k8s-github-robot assigned zmerlynn Jul 7, 2016

k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Jul 7, 2016

pmorie added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jul 7, 2016

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2016

k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 8, 2016

googlebot added cla: yes and removed cla: no labels Jul 11, 2016

thockin assigned saad-ali and unassigned zmerlynn Jul 18, 2016

thockin reviewed Jul 18, 2016
View reviewed changes

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2016

akutz mentioned this pull request Jul 18, 2016

Optional TOML Support (disabled by default) spf13/viper#208

Closed

vladimirvivien mentioned this pull request Jul 26, 2016

Kubernetes and libStorage thecodeteam/roadmap#133

Closed

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2016

k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 20, 2016

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2017

vladimirvivien added 3 commits January 4, 2017 10:01

LibStorage generated artifacts

fada4bc

This commit encapsulates all source and doc artifacts generated by the build scripts including - API documentations - Source code for API types - Other build artifacts - Etc

LibStorage volume plugin example documentation

4d073df

This commit includes all example documentation showing how to use the libStorage Kuberneties volume plugin.

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2017

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2017

k8s-github-robot assigned bgrant0607 and unassigned saad-ali Jan 30, 2017

apelisse assigned saad-ali Jan 31, 2017

k8s-github-robot assigned wojtek-t Jan 31, 2017

wojtek-t removed their assignment Feb 10, 2017

bgrant0607 assigned thockin and unassigned bgrant0607 Feb 28, 2017

grodrigues3 added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2017

vladimirvivien closed this Jun 7, 2017

vladimirvivien deleted the feature/libstorage branch June 7, 2017 20:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for libStorage as a Kubernetes volume plugin. #28599

Add support for libStorage as a Kubernetes volume plugin. #28599

vladimirvivien commented Jul 7, 2016 •

edited by k8s-oncall

Loading

googlebot commented Jul 7, 2016

eparis commented Jul 7, 2016

eparis commented Jul 7, 2016

pmorie commented Jul 7, 2016

eparis commented Jul 7, 2016

vladimirvivien commented Jul 7, 2016

vladimirvivien commented Jul 8, 2016

k8s-bot commented Jul 11, 2016

vladimirvivien commented Jul 11, 2016

googlebot commented Jul 11, 2016

vladimirvivien commented Jul 11, 2016

rootfs commented Jul 17, 2016

thockin Jul 18, 2016

cantbewong Jul 18, 2016 •

edited

Loading

k8s-github-robot commented Jan 3, 2017

k8s-ci-robot commented Jan 4, 2017

vladimirvivien commented Jan 4, 2017

k8s-ci-robot commented Jan 4, 2017

k8s-github-robot commented Jan 9, 2017

k8s-github-robot commented Jan 23, 2017

Add support for libStorage as a Kubernetes volume plugin. #28599

Add support for libStorage as a Kubernetes volume plugin. #28599

Conversation

vladimirvivien commented Jul 7, 2016 • edited by k8s-oncall Loading

googlebot commented Jul 7, 2016

eparis commented Jul 7, 2016

eparis commented Jul 7, 2016

pmorie commented Jul 7, 2016

eparis commented Jul 7, 2016

vladimirvivien commented Jul 7, 2016

vladimirvivien commented Jul 8, 2016

k8s-bot commented Jul 11, 2016

vladimirvivien commented Jul 11, 2016

googlebot commented Jul 11, 2016

vladimirvivien commented Jul 11, 2016

rootfs commented Jul 17, 2016

thockin Jul 18, 2016

Choose a reason for hiding this comment

cantbewong Jul 18, 2016 • edited Loading

Choose a reason for hiding this comment

k8s-github-robot commented Jan 3, 2017

k8s-ci-robot commented Jan 4, 2017

vladimirvivien commented Jan 4, 2017

k8s-ci-robot commented Jan 4, 2017

k8s-github-robot commented Jan 9, 2017

k8s-github-robot commented Jan 23, 2017

vladimirvivien commented Jul 7, 2016 •

edited by k8s-oncall

Loading

cantbewong Jul 18, 2016 •

edited

Loading