Release 1.3 - batch 2 #28309
Closed
Release 1.3 - batch 2 #28309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs-nodebootstrap
Automatic merge from submit-queue
Substitute federation_domain_map parameter with its value in node bootstrap scripts.
This PR also removes the substitution code we added to the build scripts.
**Release Note**
```release-note
If you use one of the kube-dns replication controller manifest in `cluster/saltbase/salt/kube-dns`, i.e. `cluster/saltbase/salt/kube-dns/{skydns-rc.yaml.base,skydns-rc.yaml.in}`, either substitute one of `__PILLAR__FEDERATIONS__DOMAIN__MAP__` or `{{ pillar['federations_domain_map'] }}` with the corresponding federation name to domain name value or remove them if you do not support cluster federation at this time. If you plan to substitute the parameter with its value, here is an example for `{{ pillar['federations_domain_map'] }`
pillar['federations_domain_map'] = "- --federations=myfederation=federation.test"
where `myfederation` is the name of the federation and `federation.test` is the domain name registered for the federation.
```
cc @erictune @kubernetes/sig-cluster-federation @MikeSpreitzer @luxas
[]()
(cherry picked from commit 3a6494e)
Automatic merge from submit-queue Create a PD volume when deploying the federation with federation-up. (cherry picked from commit 1d9b614)
Signed-off-by: Vishnu Kannan <vishnuk@google.com> Signed-off-by: Vishnu kannan <vishnuk@google.com>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
david-mcmahon
added
cla: yes
priority/critical-urgent
|
This PR is not for the master branch but does not have the |
k8s-github-robot
added
do-not-merge
david-mcmahon
added
cherry-pick-approved
|
Labelling this PR as size/L |
k8s-github-robot
added
size/L
|
GCE e2e build/test passed for commit 3b12872. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28258: Allow opting out of automatic cloud provider detection in kubelet. By default kubelet will auto-detect cloud providers
#28132: Substitute federation_domain_map parameter with its value in node bootstrap scripts.
#28261: Create a PD volume when deploying the federation with federation-up.
cc @eparis Doing our own version of your PR.